Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling #2

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Update styling #2

merged 1 commit into from
Oct 31, 2020

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 30, 2020

Several styling improvements, see below for before and after images:

  • Align link and text colors
    image image

  • Add horizontal padding to body
    image image

  • Use same font for inline code as for code blocks
    image image

  • Use download-link styling for the "Download"-button
    image image

  • Highlight npm-download command
    image
    image

@joshgoebel fyi

@joshgoebel
Copy link
Member

@isagalaev After we update this do you have to take some manual action to deploy it?

@joshgoebel joshgoebel merged commit 5df545f into highlightjs:master Oct 31, 2020
@isagalaev
Copy link
Member

After we update this do you have to take some manual action to deploy it?

Done!

@isagalaev
Copy link
Member

btw, links in brighter white were intentional :-)

@Hirse
Copy link
Contributor Author

Hirse commented Oct 31, 2020

btw, links in brighter white were intentional :-)

My bad. As the colors were so close, I couldn't tell.
Would you like me to make a revert PR for that part?

@isagalaev
Copy link
Member

Nah… I don't really care either way. They are indeed too close!

@Hirse
Copy link
Contributor Author

Hirse commented Oct 31, 2020

Would either of you mind tagging this with the hacktoberfest-accepted?
I should be over the limit, but I would like all of them to be counted. 😄

@joshgoebel
Copy link
Member

links in brighter white were intentional :-)

I kind of wondered, but if it's too subtle to see (I couldn't visually discern the difference) then as you said, too close. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants