Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Demo and Website styling #2805

Merged
merged 7 commits into from
Nov 6, 2020
Merged

Align Demo and Website styling #2805

merged 7 commits into from
Nov 6, 2020

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Oct 30, 2020

Aligning the demo-page with the overall website styling.
Also see highlightjs/hljs_org#2

Changes

  • Use same fonts as website ("PT Sans" for text, "Consolas" for code)
    before
    image
    after
    image
  • Use CSS scrollbars and remove "perfect-scrollbar"
    image
  • Align link and text colors
  • Set min-width on content
  • Use thin scrollbar for code (on Firefox)

Checklist

  • Added markup tests, N/A, only demo website changes
  • Updated the changelog at CHANGES.md No changes to the library
  • Added myself to AUTHORS.txt, under Contributors Already there 😉

@joshgoebel
Copy link
Member

I'll fetch this local to play with later, but it's probably fine. :) Nice to see perfect scrollbar die.

@joshgoebel joshgoebel added the hacktoberfest-accepted Hacktoberfest label Oct 31, 2020
@joshgoebel joshgoebel added this to the 10.4 milestone Oct 31, 2020
@joshgoebel joshgoebel merged commit d95f1bc into highlightjs:master Nov 6, 2020
@joshgoebel
Copy link
Member

@Hirse Thanks so much! I made a few small tweaks here and there.

@Hirse Hirse deleted the demo-styling branch November 7, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest
Projects
None yet
Milestone
10.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Hirse @joshgoebel