nit: resolve PR comments

Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java

@@ -35,8 +35,6 @@
 import com.swirlds.common.platform.NodeId;
 import com.swirlds.common.stream.RunningEventHashOverride;
 import com.swirlds.common.utility.AutoCloseableWrapper;
-import com.swirlds.component.framework.component.ComponentWiring;
-import com.swirlds.component.framework.wires.input.InputWire;
 import com.swirlds.platform.builder.PlatformBuildingBlocks;
 import com.swirlds.platform.builder.PlatformComponentBuilder;
 import com.swirlds.platform.components.AppNotifier;
@@ -45,7 +43,6 @@
 import com.swirlds.platform.components.DefaultSavedStateController;
 import com.swirlds.platform.components.EventWindowManager;
 import com.swirlds.platform.components.SavedStateController;
-import com.swirlds.platform.components.consensus.ConsensusEngine;
 import com.swirlds.platform.config.StateConfig;
 import com.swirlds.platform.consensus.EventWindow;
 import com.swirlds.platform.crypto.KeysAndCerts;
@@ -57,7 +54,6 @@
 import com.swirlds.platform.event.preconsensus.PcesFileTracker;
 import com.swirlds.platform.event.preconsensus.PcesReplayer;
 import com.swirlds.platform.eventhandling.EventConfig;
-import com.swirlds.platform.internal.ConsensusRound;
 import com.swirlds.platform.metrics.RuntimeMetrics;
 import com.swirlds.platform.pool.TransactionPoolNexus;
 import com.swirlds.platform.publisher.DefaultPlatformPublisher;
@@ -214,7 +210,7 @@
         logger.info(STARTUP.getMarker(), "Starting with roster history:\n{}", blocks.rosterHistory());
         currentRoster = blocks.rosterHistory().getCurrentRoster();
 
-        platformWiring = new PlatformWiring(platformContext, blocks.model(), blocks.applicationCallbacks());
+        platformWiring = blocks.platformWiring();
 
         registerRosterMetrics(platformContext.getMetrics(), currentRoster, selfId);
 
@@ -526,15 +522,4 @@
                 ? AutoCloseableWrapper.empty()
                 : new AutoCloseableWrapper<>((T) wrapper.get().getState(), wrapper::close);
     }
-
-    /**
-     * Binds a custom input wire to the consensus engine output wire. This method is mainly created for test purposes.
-     *
-     * @param inputWire to bind
-     */
-    public void bindInputWireToConsensusEngine(final InputWire<List<ConsensusRound>> inputWire) {
-        final ComponentWiring<ConsensusEngine, List<ConsensusRound>> consensusEngineWiring =
-                platformWiring.getConsensusEngineWiring();
-        consensusEngineWiring.getOutputWire().solderTo(inputWire);
-    }
 }

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformBuilder.java

@@ -64,6 +64,7 @@
 import com.swirlds.platform.system.SoftwareVersion;
 import com.swirlds.platform.system.status.StatusActionSubmitter;
 import com.swirlds.platform.util.RandomBuilder;
+import com.swirlds.platform.wiring.PlatformWiring;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import java.io.IOException;
 import java.io.UncheckedIOException;
@@ -486,6 +487,8 @@
             randomBuilder = new RandomBuilder();
         }
 
+        final PlatformWiring platformWiring = new PlatformWiring(platformContext, model, callbacks);
+
         final PlatformBuildingBlocks buildingBlocks = new PlatformBuildingBlocks(
                 platformContext,
                 model,
@@ -515,7 +518,8 @@
                 new AtomicReference<>(),
                 firstPlatform,
                 stateLifecycles,
-                platformStateFacade);
+                platformStateFacade,
+                platformWiring);
 
         return new PlatformComponentBuilder(buildingBlocks);
     }

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformBuildingBlocks.java

@@ -39,6 +39,7 @@
 import com.swirlds.platform.system.SoftwareVersion;
 import com.swirlds.platform.system.status.StatusActionSubmitter;
 import com.swirlds.platform.util.RandomBuilder;
+import com.swirlds.platform.wiring.PlatformWiring;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
 import java.time.Instant;
@@ -97,6 +98,7 @@
  *                                               reconnect, can be removed once reconnect is made compatible with the
  *                                               wiring framework
  * @param platformStateFacade                    the facade to access the platform state
+ * @param platformWiring                         the wiring to use inside the platform
  */
 public record PlatformBuildingBlocks(
         @NonNull PlatformContext platformContext,
@@ -127,7 +129,8 @@
         @NonNull AtomicReference<Runnable> clearAllPipelinesForReconnectReference,
         boolean firstPlatform,
         @NonNull StateLifecycles stateLifecycles,
-        @NonNull PlatformStateFacade platformStateFacade) {
+        @NonNull PlatformStateFacade platformStateFacade,
+        @NonNull PlatformWiring platformWiring) {
 
     public PlatformBuildingBlocks {
         requireNonNull(platformContext);
@@ -154,5 +157,6 @@
         requireNonNull(getLatestCompleteStateReference);
         requireNonNull(loadReconnectStateReference);
         requireNonNull(clearAllPipelinesForReconnectReference);
+        requireNonNull(platformWiring);
     }
 }

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformComponentBuilder.java

@@ -103,6 +103,7 @@
 import com.swirlds.platform.system.status.DefaultStatusStateMachine;
 import com.swirlds.platform.system.status.StatusStateMachine;
 import com.swirlds.platform.util.MetricsDocUtils;
+import com.swirlds.platform.wiring.PlatformWiring;
 import com.swirlds.platform.wiring.components.Gossip;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import java.io.IOException;
@@ -212,8 +213,8 @@
         used = true;
 
         try (final ReservedSignedState initialState = blocks.initialState()) {
             swirldsPlatform = new SwirldsPlatform(this);
             return swirldsPlatform;
         } finally {
             if (metricsDocumentationEnabled) {
                 // Future work: eliminate the static variables that require this code to exist
@@ -229,13 +230,16 @@
     }
 
     /**
-     * Binds a custom input wire to the consensus engine output wire. This method is mainly created for test purposes.
+     * Binds a custom input wire to the consensus engine output wire.
      *
-     * @param inputWire to bind
+     * @param inputWire with matching type of consensus engine output to bind
      */
-    public void bindInputWireToConsensusEngine(final InputWire<List<ConsensusRound>> inputWire) {
-        swirldsPlatform.bindInputWireToConsensusEngine(inputWire);
+    public void withInputWireToConsensusEngine(final InputWire<List<ConsensusRound>> inputWire) {
+        final PlatformWiring platformWiring = blocks.platformWiring();
+        final ComponentWiring<ConsensusEngine, List<ConsensusRound>> consensusEngineWiring =
+                platformWiring.getConsensusEngineWiring();
+        consensusEngineWiring.getOutputWire().solderTo(inputWire);
     }
 
     /**
      * If enabled, building this object will cause a metrics document to be generated. Default is true.

platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java

@@ -176,7 +176,7 @@ public class TurtleNode {
 
         final InputWire<List<ConsensusRound>> consensusRoundsHolderInputWire =
                 consensusRoundsHolderWiring.getInputWire(ConsensusRoundsHolder::interceptRounds);
-        platformComponentBuilder.bindInputWireToConsensusEngine(consensusRoundsHolderInputWire);
+        platformComponentBuilder.withInputWireToConsensusEngine(consensusRoundsHolderInputWire);
     }
 
     /**