test: solder test input wire for TurleTests to StateSignatureCollector output wire #17864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sEngine Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
…mponent-to-collect-rounds-from-ConsensusEngine # Conflicts: # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…collect-rounds-from-ConsensusEngine' into 17639-connect-test-component-to-StateSignatureCollector-output
…r output wire Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
…collect-rounds-from-ConsensusEngine' into 17639-connect-test-component-to-StateSignatureCollector-output
IvanKavaldzhiev
added
Test Development
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17638-connect-test-component-to-collect-rounds-from-ConsensusEngine #17864 +/- ##
=========================================================================================================
- Coverage 69.00% 69.00% -0.01%
- Complexity 23035 23037 +2
=========================================================================================================
Files 2654 2654
Lines 99668 99675 +7
Branches 10287 10287
=========================================================================================================
+ Hits 68775 68779 +4
- Misses 26993 27002 +9
+ Partials 3900 3894 -6
... and 12 files with indirect coverage changes |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
…mponent-to-collect-rounds-from-ConsensusEngine
…atformBuilder Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
…mponent-to-collect-rounds-from-ConsensusEngine
…mponent-to-collect-rounds-from-ConsensusEngine
…collect-rounds-from-ConsensusEngine' into 17639-connect-test-component-to-StateSignatureCollector-output # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformComponentBuilder.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Base automatically changed from
17638-connect-test-component-to-collect-rounds-from-ConsensusEngine
to
main
February 20, 2025 08:35
…mponent-to-StateSignatureCollector-output # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/PlatformWiring.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleNode.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/turtle/consensus/ConsensusRoundsHolder.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/turtle/consensus/ConsensusRoundsListContainer.java Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
lpetrovic05
reviewed
Feb 20, 2025
| * @return the wiring for the state signature collector | ||
| */ | ||
| @NonNull | ||
| public OutputWire<List<ReservedSignedState>> getStateSignatureCollectorWiring() { |
There was a problem hiding this comment.
we cannot use the output of the collector directly, it needs to go through a reserver first
lpetrovic05
reviewed
Feb 20, 2025
Comment on lines
+11
to
+18
| final List<ReservedSignedState> collectedSignedStates = new ArrayList<>(); | ||
|
|
||
| @Override | ||
| public void interceptSignedStates(@NonNull final List<ReservedSignedState> signedStates) { | ||
| if (!signedStates.isEmpty()) { | ||
| collectedSignedStates.addAll(signedStates); | ||
| } | ||
| } |
There was a problem hiding this comment.
we should not keep these signed states for the whole run, this could lead to a OOM
There was a problem hiding this comment.
Agree, I think this issue is also relevant in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR defines a test component inside TurtleTests and wires it to collect ReservedSignedStates coming from StateSignatureCollector.
Related issue(s):
Fixes #17639
Notes for reviewer:
Checklist