Skip to content

Upgrade to Vert.x 4.1.4 #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2021
Merged

Upgrade to Vert.x 4.1.4 #966

merged 3 commits into from
Sep 22, 2021

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Sep 20, 2021

Fixes #955

@DavideD DavideD requested a review from Sanne September 20, 2021 10:16
@DavideD
Copy link
Member Author

DavideD commented Sep 20, 2021

@Sanne Quarkus seems to be still on 4.1.3, any particular reason?

@Sanne
Copy link
Member

Sanne commented Sep 20, 2021

I'm not sure. I suspect the team didn't get to it yet as it was just released :) Let's give them a couple days to test?

But we could merge this if you need it quickly, since there are no code changes it should be easy to override the versions in Quarkus (in worse case); just be careful in tracking 4.1.4 specific funcionality in subsequent patches, in the remote case in which this would need to be reverted.

@DavideD
Copy link
Member Author

DavideD commented Sep 20, 2021

I prefer to wait for quarkus. This version is needed for #911 and #912 but we haven't a pr yet

@gbadner
Copy link
Contributor

gbadner commented Sep 20, 2021

Looks like eclipse-vertx/vertx-sql-client#1033 didn't get fixed in 4.1.4, so DB2 "grouped" strategy will still be broken.

@gbadner gbadner mentioned this pull request Sep 21, 2021
Closed
@DavideD
Copy link
Member Author

DavideD commented Sep 21, 2021

Looks like eclipse-vertx/vertx-sql-client#1033 didn't get fixed in 4.1.4, so DB2 "grouped" strategy will still be broken.

That's ok for me. We can focus on MSSQL and we will fix Db2 when we can

Sanne
Sanne approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Quarkus upgrade was merged: quarkusio/quarkus#20308

@Sanne Sanne merged commit fed4381 into hibernate:main Sep 22, 2021
@DavideD DavideD deleted the 955-Vert.x-4.1.4 branch October 12, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Vert.x to 4.1.4
3 participants
@DavideD @Sanne @gbadner