912 : SchemaMigrator/SchemaValidator support for MS SQL Server #967
Conversation
Remove SqlServerReactiveInformationExtractorImpl#getDatabaseSchemaColumnName
gbadner
force-pushed
the
912-schema-update-sql-server-1
branch
from
28e69da to
49151ec
Compare
|
I pushed a minor update, and force-pushed to resolve conflict. |
|
This PR doesn't fail if I test it using ORM 5.6.0.Beta2. Is that correct? |
|
@DavideD, it will still fail with ORM 5.6.Beta2. It requires hibernate/hibernate-orm#4235, which has not been merged yet. |
|
Is it supposed to fail for MSSQL and Db2? |
|
I've rebased this branch to the latest changes and sent a new PR that uses the grad.properties in master: #970 |
I've answered myself, the test is only for MSSQL |
|
|
||
| @Test | ||
| public void testValidationSucceed(TestContext context) { | ||
| Configuration createHbm2ddlConf = constructConfiguration( "validate" ); |
There was a problem hiding this comment.
I guess this should be called validateHbm2ddlConf
There was a problem hiding this comment.
I would prefer the generic configuration, as used in the other tests.
WDYT?
There was a problem hiding this comment.
I find validateHbm2ddlConf clearer but configuration works as well.
I'm happy as long as it is not createHbm2ddlConf :-)
There was a problem hiding this comment.
I prefer more generic names when it's unambiguous, to avoid future copy/paste errors.
Anyhow, I've fixed it in #970
| // actually checks). | ||
| @Test | ||
| public void testValidationFails(TestContext context) { | ||
| Configuration createHbm2ddlConf = constructConfiguration( "validate" ); |
There was a problem hiding this comment.
I guess this should be called validateHbm2ddlConf
There was a problem hiding this comment.
I would prefer the generic configuration, as used in the other tests.
WDYT?
#912
Includes #966
Requires ORM PR: hibernate/hibernate-orm#4235