Skip to content

[912] SchemaMigrator/SchemaValidator support for MS SQL Server #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

[912] SchemaMigrator/SchemaValidator support for MS SQL Server #945

wants to merge 15 commits into from

Conversation

gbadner
Copy link
Contributor

@gbadner gbadner commented Aug 31, 2021

gbadner added 15 commits August 30, 2021 10:55
@gbadner
[536] SchemaMigrator support for PostgreSQL
87f8d3a
@gbadner
[536] Correct order of arguments to TestContext#assertEquals
ec3a067
@gbadner
[536] : Change SQL keywords to lowercase
2297914
@gbadner
[536] Encapsulate extraction methods into ReactiveExtractionTool
111fc03 
[536] : Added Javodoc, made minor changes to sych up with ORM, changed more SQL keywords that were upper-case to lower-case
@gbadner
[536] : Use org.hibernate.reactive.pool.impl.Parameters#process for d…
41e8311 
…ialect-specific parameter placeholders
@gbadner
[536] : Add a method for non-standard information_schema.columns colu…
b440eea 
…mn name used by PostgreSQL
@gbadner
[536] Change ResultSetAdapter#getLong(String) to be convert String …
c26d2dc 
…to Long
@gbadner
[536] Change ResultSetAdapter#getLong(String) to throw the original…
e038a6f 
… exception if the value is neither a long nor a String that can be parsed as a long.
@gbadner
[913] SchemaMigrator/SchemaValidator support for CockroachDB
d115838
@gbadner
[536] [913] Comment out settings in gradle.properties
51a4a44
@gbadner
[910] SchemaMigrator/SchemaValidator support for MySQL
afbafdf
@gbadner
[910] Fix off-by-one bug in ResultSetAdaptor#getXXX(int columnIndex) …
d654fd9 
…methods
@gbadner
[910] SchemaMigrator/SchemaValidator support for MariaDB
38c1e39
@gbadner
[910] Improve Javadoc; simplify MySqlReactiveInformationExtractorImpl…
fa1b8b5 
… methods
@gbadner
[912] SchemaMigrator/SchemaValidator support for MS SQL Server
76466cd
@gbadner gbadner mentioned this pull request Aug 31, 2021
Closed
@gbadner
Copy link
Contributor Author

gbadner commented Aug 31, 2021

This is not ready for review yet. I created this draft PR so that the exception mentioned here can be reproduced.

The ORM PR (hibernate/hibernate-orm#4177) is required to reproduce.

All SchemaUpdateSqlServerTestBase$GroupedSchemaUpdateSqlServerTestBase tests fail due to:

java.util.concurrent.CompletionException: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: index: 8, length: 4088 (expected: range(0, 53))

@gbadner gbadner mentioned this pull request Sep 1, 2021
Closed
@gbadner
Copy link
Contributor Author

gbadner commented Sep 21, 2021

This is out-of-date.

@gbadner gbadner closed this Sep 21, 2021
@gbadner gbadner deleted the 912-schema-update-sql-server branch September 21, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gbadner