HHH-14794 : More changes to support SchemaMigrator/SchemaValidator using Hibernate Reactive #4177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing Hibernate Reactive Changes required by SQL Server
This was referenced Aug 31, 2021
Closed
|
Hi @gbadner ! Looks fine - is it intended to stay as a draft? We can release more frequently if that helps with the work on the HR side, let me know. |
|
@Sanne I personally would love to see that. |
Sanne
reviewed
Sep 7, 2021
| @@ -248,4 +251,10 @@ public String getCreateTemporaryTableColumnAnnotation(int sqlTypeCode) { | |||
| return ""; | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public NameQualifierSupport getNameQualifierSupport() { | |||
There was a problem hiding this comment.
Interesting that this was missing. Perhaps it deserves its own JIRA so to highlight the change better in changelogs?
|
@gbadner I haven't heard back, but this looks totally fine so I'll start merging this. If you have more changes please send more PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14794