Repository navigation
fix(cli): preserve literal WebVTT cue text - #5236
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Escaping &, < and > on export is what the WebVTT spec requires, and decoding character references once on import makes an export followed by a re-import round-trip correctly. The tests cover the important edge cases. One ordering note: with decoding in place, an imported </script> becomes a literal </script> that reaches patchCaptionHtml, so this should land after #5226, which escapes it there. Minor and optional: the linkedom document could be created once per parse instead of once per cue.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebVTT sidecars write normalized transcript text directly as cue markup. A literal
<config>disappears when Chrome displays the cue, and literal<becomes<. Importing encoded cues also keeps entity spellings instead of their displayed characters, so export/import does not preserve the text.Escape ampersands and angle brackets in exported WebVTT payloads, and decode imported character references once after the existing tag removal. Reuse the existing
linkedomdependency, protect literal less-than signs before entity decoding, and skip decoding for plain cues without ampersands. Add literal-text round trips and encoded payload cases, including numeric entities, actual cue formatting, unknown entities, and bidirectional marks.Validation: