Repository navigation
fix(cli): preserve caption text inside script blocks - #5226
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Two real escaping gaps in the caption patcher. A literal </script> in word text closes the host script, and $&, $' or $$ in the text are expanded by String.replace. Escaping < matches what Studio's caption generator already does, and the replacement callback removes the dollar-pattern expansion. The tests fail on main and pass here. Please land this before or together with #5236, which makes a decoded < reachable from VTT imports.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing caption text containing
</script>throughhyperframes transcribecan close the destination script and turn part of the caption into HTML. Replacement-string sequences such as$&and$$also change the text or word IDs during insertion.Escape
<after JSON serialization and insert the serialized data through a replacement callback. This applies Studio's existing script-data convention to the CLI patcher and preserves literal caption text, IDs and timing for both supported variable names.Validation:
This follows the generator fix in #3847. Transcript array-boundary parsing in #3896 remains separate.