Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests; bump shUnit2 to 2.1.8 #934

Merged
merged 10 commits into from
Aug 11, 2021
Merged

Fix broken tests; bump shUnit2 to 2.1.8 #934

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a50567d
Update shunit2
joshwlewis Aug 9, 2021
a8028eb
Use assertContains from shunit2 for unit tests
joshwlewis Aug 9, 2021
96b628a
Update node, bower, jQuery for ancient, failing fixture
joshwlewis Aug 10, 2021
4ded7fc
Add yarn 1.22.11 to yarn version cache
joshwlewis Aug 11, 2021
ed02061
Be less specific about yarn version resolution tests
joshwlewis Aug 11, 2021
ebd83e3
Drop assertContains and assertNotContains. These are provided by shunit2
joshwlewis Aug 11, 2021
77c5efe
Use regex to match against minor and patch level during resolution
joshwlewis Aug 11, 2021
2cc5895
Update node inventory
joshwlewis Aug 11, 2021
49f4806
Re-introduce node resolve-version tests, with less specificity on min…
joshwlewis Aug 11, 2021
49df608
Update changelog with test fixes and updates
joshwlewis Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update node, bower, jQuery for ancient, failing fixture
  • Loading branch information
@joshwlewis
joshwlewis committed Aug 10, 2021
commit 96b628a32d7638e78dc9728e2b61a14c8545372f
2 changes: 1 addition & 1 deletion test/fixtures/cache-directories/bower.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-buildpack-test-app",
"dependencies": {
"jquery": "^1.11.1"
"jquery": "^3.6.0"
}
}
15 changes: 9 additions & 6 deletions test/fixtures/cache-directories/package.json
View file
Original file line number Diff line number Diff line change
@@ -2,18 +2,21 @@
"name": "node-buildpack-test-app",
"version": "0.0.1",
"description": "node buildpack integration test app",
"repository" : {
"type" : "git",
"url" : "http://github.com/example/example.git"
"repository": {
"type": "git",
"url": "http://github.com/example/example.git"
},
"engines": {
"node": "8.x"
"node": "12.x"
},
"dependencies": {
"bower": "1.3.12"
"bower": "1.8.12"
},
"scripts": {
"postinstall": "bower install --allow-root"
},
"cache_directories": ["bower_components", "node_modules"]
"cache_directories": [
"bower_components",
"node_modules"
]
}