Fix broken tests; bump shUnit2 to 2.1.8 #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
changed the title
…or and patch levels
edmorley
approved these changes
Aug 11, 2021
lillianzhang331
approved these changes
Aug 11, 2021
edmorley
added a commit
that referenced
this pull request
Oct 3, 2021
To fix CI on `main`, now that there are newer Yarn versions, which cause `testBuildMetaData` to fail, the same as it did in #934. GUS-W-9981764.
edmorley
added a commit
that referenced
this pull request
Oct 4, 2021
To fix CI on `main`, now that there are newer Yarn versions, which cause `testBuildMetaData` to fail, the same as it did in #934. GUS-W-9981764.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some recent failures in CI. This PR fixes the following issues:
This appears to be due to using an ancient and vulnerable version of jQuery in the
cache-directoriesfixture. I've updated thenode,bower, andjQueryversions for this fixture.This was due to a newer release of yarn becoming available, 1.22.11. The problem here is twofold. 1) inventory/yarn.toml needs the new entry 2) these tests were not tolerant to version changes.
Additionally, this PR bumps
shunitto 2.1.8. The previous version, 2.1.6 is over 10 years old. By bumping the version, we can now run single tests with a command liketest/run -- testBuildWithUserCacheDirectories. The newshunit2comes with a newassertContains()function which conflicted with our own method of the same name.