Skip to content

Commit

Permalink
Stop running test-packages twice in PhantomJS.
Browse files Browse the repository at this point in the history
During the Meteor 1.6.1 beta period, we introduced logic to render a
<script> tag to load the SockJS library in older browsers (meteor#9353), and so
it seemed important to run test-packages both with and without the
<script> tag, using a special query parameter appended to the app URL.

The meteor#9353 changes were ultimately reverted before Meteor 1.6.1 was
released (see 3658042), and Meteor 1.6.2
will take a very different approach to bundling dependencies like SockJS
for legacy browsers (meteor#9439). As part of this approach, PhantomJS is always
considered a legacy browser, and as such provides valuable feedback on the
behavior of web.browser.legacy bundles. However, since there's nothing to
configure with regard to SockJS anymore, there's no point in running the
test-packages suite twice in PhantomJS.

In order to run these tests in a modern browser environment, we should
probably revisit the idea of running tests in headless Chrome:
meteor/meteor-feature-requests#254
  • Loading branch information
Ben Newman committed Feb 8, 2018
1 parent 640011a commit c27b741
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/test-in-console/package.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package.describe({
summary: "Run tests noninteractively, with results going to the console.",
version: '1.2.1'
version: '1.2.2'
});

Package.onUse(function (api) {
Expand Down
3 changes: 2 additions & 1 deletion packages/test-in-console/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ var system = require("system");
var platform = system.args[1] || "local";
var platformUrl = system.env.URL + platform;
var testUrls = [
// Additional application URLs can be added here to re-run tests in
// PhantomJS with different query parameter-based configurations.
platformUrl,
platformUrl + "?force_sockjs=1",
];

function runNextUrl() {
Expand Down

0 comments on commit c27b741

Please sign in to comment.