Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

[Up for grabs] Switch Meteor's headless browser tests from PhantomJS to Headless Chrome #254

Open
hwillson opened this issue Jan 16, 2018 · 3 comments
Open

[Up for grabs] Switch Meteor's headless browser tests from PhantomJS to Headless Chrome #254

hwillson opened this issue Jan 16, 2018 · 3 comments
Labels
pull-requests-encouraged

Comments

@hwillson
Copy link
Contributor

Migrated from meteor/meteor#8659.

PhantomJS has been showing its age for several years now, and the new --headless support in Chrome 59 seems like a much better fit for running our client-side integration tests: https://developers.google.com/web/updates/2017/04/headless-chrome

Here's an example of a similar issue/discussion on another project (GitLab): https://gitlab.com/gitlab-org/gitlab-ce/issues/30876

Relevant starting points:

I realize these instructions are woefully incomplete, but I hope this is enough to get discussion started, and (with any luck) identify contributors who would find this work interesting.
@hwillson hwillson mentioned this issue Jan 16, 2018
Closed
benjamn pushed a commit to meteor/meteor that referenced this issue Feb 8, 2018
Stop running test-packages twice in PhantomJS.
c27b741 
During the Meteor 1.6.1 beta period, we introduced logic to render a
<script> tag to load the SockJS library in older browsers (#9353), and so
it seemed important to run test-packages both with and without the
<script> tag, using a special query parameter appended to the app URL.

The #9353 changes were ultimately reverted before Meteor 1.6.1 was
released (see 3658042), and Meteor 1.6.2
will take a very different approach to bundling dependencies like SockJS
for legacy browsers (#9439). As part of this approach, PhantomJS is always
considered a legacy browser, and as such provides valuable feedback on the
behavior of web.browser.legacy bundles. However, since there's nothing to
configure with regard to SockJS anymore, there's no point in running the
test-packages suite twice in PhantomJS.

In order to run these tests in a modern browser environment, we should
probably revisit the idea of running tests in headless Chrome:
meteor/meteor-feature-requests#254
@benjamn benjamn mentioned this issue Feb 8, 2018
Merged
@mitar
Copy link

mitar commented Mar 5, 2018

BTW, I am not sure why it would necessary to be used headless. I am using selenium + xvfb + chromium and it already works well. This is how one runs it. Runner I use. I have not yet tried recent headless support. What I am trying to say is that this should be very easy.

(Some links above do not resolve anymore.)

@toinevk
Copy link

toinevk commented Apr 13, 2018

Hey @mitar, have you got any further experience with this? I've been playing around with it trying Puppeteer, Chrome Launcher + Chrome Remote Interface and Selenium but test seem to fail because Meteor.isClient remains false.

@mitar
Copy link

mitar commented Apr 13, 2018

I have not done anything more. My approach works for me for now.

@toinevk toinevk mentioned this issue Apr 14, 2018
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pull-requests-encouraged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hwillson @mitar @toinevk