Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Errors using miette #103

Merged
merged 60 commits into from
Oct 13, 2023
Merged

Improve Errors using miette #103

Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
8e46782
use thiserror for granular errors
asmello Sep 29, 2023
e4f3f92
uncomment local registry module
asmello Sep 29, 2023
7910a2a
add doc-comments
asmello Sep 29, 2023
8a329af
Merge branch 'main' into amello/thiserror
asmello Sep 29, 2023
bf8ef05
make changes to generate command stuff
asmello Sep 29, 2023
b8371ee
fix typo
asmello Sep 29, 2023
0bdfc2f
fix typo
asmello Sep 29, 2023
d35e251
fix inverted test
asmello Sep 29, 2023
4257574
rework errors
asmello Oct 3, 2023
bebba3d
some leftover cleanup
asmello Oct 3, 2023
70f79d6
more tweaks
asmello Oct 3, 2023
144138f
Merge branch 'main' into amello/thiserror
asmello Oct 3, 2023
1ea79de
Merge branch 'main' into amello/thiserror
asmello Oct 4, 2023
ef92502
Merge branch 'main' into amello/thiserror
asmello Oct 4, 2023
d9643b1
improve some error messages
asmello Oct 4, 2023
c542618
MVP
asmello Oct 6, 2023
c81ec9f
remove displaydoc
asmello Oct 6, 2023
91b2532
remove http errors
asmello Oct 6, 2023
e4a57cf
Merge branch 'main' into amello/alternative
asmello Oct 6, 2023
df74971
remove contextcompat from command mod
asmello Oct 6, 2023
c0585a8
undo unintentional feature flag condition change
asmello Oct 6, 2023
4cf861e
some tweaks to minimise changes
asmello Oct 6, 2023
9d692fc
add FileExistsError
asmello Oct 6, 2023
2d25120
more tweaks to minimise changes
asmello Oct 6, 2023
437e086
more tweaks
asmello Oct 6, 2023
9cac469
switch a bunch of bails to ensures
asmello Oct 6, 2023
6078c5b
last tweaks for today
asmello Oct 6, 2023
16f5554
use imports
asmello Oct 10, 2023
ab06839
Merge branch 'main' into amello/alternative
asmello Oct 10, 2023
0e4a10e
remove eyre prefix in bail
asmello Oct 10, 2023
da7fa15
switch to miette
asmello Oct 10, 2023
d5a1d1d
Apply suggestions from code review
asmello Oct 10, 2023
b14bc4d
Apply suggestions from code review
asmello Oct 10, 2023
68f0e10
avoid expect
asmello Oct 10, 2023
101b04e
Apply suggestions from code review
asmello Oct 10, 2023
ec3b963
copy changes to local.rs
asmello Oct 10, 2023
f16515b
remove unecessary clones
asmello Oct 10, 2023
3352d6c
derive diagnostic for downloaderror
asmello Oct 10, 2023
8d27b1d
introduce enum for ser/de errors
asmello Oct 10, 2023
2c9bd5f
remove some redundant error wrappers
asmello Oct 10, 2023
75ce67b
add some miette
asmello Oct 10, 2023
4e766ac
Merge branch 'main' into amello/alternative
mara-schulke Oct 11, 2023
6b52a65
fmt
asmello Oct 11, 2023
1ceaa04
Apply suggestions from code review
asmello Oct 12, 2023
f393b47
no expectations
asmello Oct 12, 2023
c98d88c
miette everywhere
asmello Oct 12, 2023
8c7f536
move BUFFRS_SUITE to const
asmello Oct 12, 2023
fb914c1
more miette
asmello Oct 12, 2023
75db404
fix credentials::write and nits
asmello Oct 12, 2023
4a2ddad
refactor request code
asmello Oct 12, 2023
e0a97a7
Merge branch 'main' into amello/alternative
asmello Oct 13, 2023
74dfc3d
Update src/package.rs
asmello Oct 13, 2023
ffe17a1
nits
asmello Oct 13, 2023
d49b5c5
revert to inline code in download
asmello Oct 13, 2023
6b73ab9
remove todo
asmello Oct 13, 2023
495b956
add doc-comment
asmello Oct 13, 2023
ab2b147
move ManagedFile to lib
asmello Oct 13, 2023
0e7f2e2
Merge branch 'main' into amello/alternative
mara-schulke Oct 13, 2023
1de378b
Merge branch 'main' into amello/alternative
mara-schulke Oct 13, 2023
7332c20
Merge branch 'main' into amello/alternative
mara-schulke Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into amello/thiserror
  • Loading branch information
@asmello
asmello authored Oct 3, 2023
commit 144138f8651c0e355984d21b84e563f0db390db5

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.