Improve Errors using miette
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mara-schulke
reviewed
Oct 9, 2023
mara-schulke
reviewed
Oct 9, 2023
mara-schulke
reviewed
Oct 9, 2023
mara-schulke
requested changes
Oct 13, 2023
There was a problem hiding this comment.
I dislike the fact that this mr does things way beyond its scope, its a bit hard to review.
The error side looks good to me mostly! Just the refactoring of existing code makes changes hard to track and bloats this. Could you eventually split refactoring the registries etc in a second pr, based on this one and revert the changes for now so we can merge this today?
Mostly lgtm! 😊
Co-authored-by: Mara Schulke <mara.schulke@helsing.ai>
mara-schulke
approved these changes
Oct 13, 2023
This was referenced Oct 13, 2023
Closed
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to implement some error reporting improvements developed for #95 while avoiding introducing new public types.
What's different from #95
Instead of introducing typed errors everywhere, I made judicious use of them only for error reusability (so that structurally similar errors need only be defined once).
This approach preserves the current pattern of defining opaque errors inline and leaking
eyre::Reportas the crate's external error type. It does not introduce any new public error types.