Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

upgrade image tag to 0.17.1 #7001

Closed
wants to merge 3 commits into from
Closed

upgrade image tag to 0.17.1 #7001

wants to merge 3 commits into from

Conversation

ravicm
Copy link

@ravicm ravicm commented Aug 5, 2018

What this PR does / why we need it:

Upgrade nginx-ingress image tag go 0.17.1

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

I am using Azure kubernetes.

$ kubectl version 
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.6", GitCommit:"9f8ebd171479bec0ada837d7ee641dec2f8c6dd1", GitTreeState:"clean", BuildDate:"2018-03-21T15:21:50Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:34:22Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

The ingress works fine on setup/startup. However, doesn't pick up any updates to Ingress objects later. I see nginx.conf not getting an update on every ingress change. The ingress controller behavior was inconsistent with 0.15.0.

After upgrade image to 0,17.1, it seems to be working fine, it's really useful to have come that by default. So that people are not losing time trying to debug the problems. This could also be achieved by passing values on the command line to helm, at the time of installation. In this case, I would recommend updating the readme with a note.

I am happy to run any kind of testing required to make this happen. Kindly guide me.

Special notes for your reviewer:
Thanks for your love.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ravicm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: scottrigby

If they are not already assigned, you can assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 5, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ravicm. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2018
@ravicm
Copy link
Author

ravicm commented Aug 5, 2018

/assign @scottrigby

@@ -5,7 +5,7 @@ controller:
name: controller
image:
repository: quay.io/kubernetes-ingress-controller/nginx-ingress-controller
tag: "0.15.0"
tag: "0.17.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the README and Chart.yaml as well (both chart version and the appVersion)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the CLA needs signing - see comments from the robot.

@jpds
Copy link
Collaborator

jpds commented Aug 6, 2018

This is missing the securityContext pieces required with the nginx upgrade (found in my linked PR).

@davidkarlsen
Copy link
Member

@jpds Nice catch.
I think this one should be closed in favour of #6745.
/close

@cpanato
Copy link
Member

cpanato commented Aug 10, 2018

/close

already merge here: #6745

@jpds
Copy link
Collaborator

jpds commented Aug 21, 2018

/close

@stale
Copy link

stale bot commented Sep 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2018
@stale
Copy link

stale bot commented Oct 4, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants