-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ravicm If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @ravicm. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @scottrigby |
@@ -5,7 +5,7 @@ controller: | |||
name: controller | |||
image: | |||
repository: quay.io/kubernetes-ingress-controller/nginx-ingress-controller | |||
tag: "0.15.0" | |||
tag: "0.17.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the README and Chart.yaml as well (both chart version and the appVersion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the CLA needs signing - see comments from the robot.
This is missing the |
/close already merge here: #6745 |
/close |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
What this PR does / why we need it:
Upgrade nginx-ingress image tag go 0.17.1
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #I am using Azure kubernetes.
The ingress works fine on setup/startup. However, doesn't pick up any updates to Ingress objects later. I see nginx.conf not getting an update on every ingress change. The ingress controller behavior was inconsistent with 0.15.0.
After upgrade image to 0,17.1, it seems to be working fine, it's really useful to have come that by default. So that people are not losing time trying to debug the problems. This could also be achieved by passing values on the command line to helm, at the time of installation. In this case, I would recommend updating the readme with a note.
I am happy to run any kind of testing required to make this happen. Kindly guide me.
Special notes for your reviewer:
Thanks for your love.