Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Upgrade to 0.17.1 #6745

Merged
merged 6 commits into from
Aug 7, 2018
Merged

[stable/nginx-ingress] Upgrade to 0.17.1 #6745

merged 6 commits into from
Aug 7, 2018

Conversation

jpds
Copy link
Collaborator

@jpds jpds commented Jul 20, 2018

What this PR does / why we need it: Upgrade to 0.17.1.

@jpds
Copy link
Collaborator Author

jpds commented Jul 20, 2018

/retest

@sebastien-prudhomme
Copy link
Contributor

Can you also update defaultbackend image to the one referenced in upstream documentation: gcr.io/google_containers/defaultbackend:1.4

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2018
@davidkarlsen
Copy link
Member

Also see #7001

@jpds
Copy link
Collaborator Author

jpds commented Aug 6, 2018

I have no idea why the pull-charts-e2e thing is failing, it just has a generic error.

@jpds
Copy link
Collaborator Author

jpds commented Aug 6, 2018

@sebastien-prudhomme Done.

@@ -5,7 +5,7 @@ controller:
name: controller
image:
repository: quay.io/kubernetes-ingress-controller/nginx-ingress-controller
tag: "0.15.0"
tag: "0.17.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the readme to match the values.yaml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -291,7 +291,7 @@ defaultBackend:
name: default-backend
image:
repository: k8s.gcr.io/defaultbackend
tag: "1.3"
tag: "1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@davidkarlsen
Copy link
Member

Reference to docs explaining why securityContext needs update: https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.16.2

@davidkarlsen
Copy link
Member

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2018
@davidkarlsen
Copy link
Member

/assign @lachie83

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, jpds, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit cfb9ff7 into helm:master Aug 7, 2018
@jpds jpds deleted the nginx-ingress-0.17.1 branch August 7, 2018 16:21
marekaf pushed a commit to marekaf/charts that referenced this pull request Sep 4, 2018
* [stable/nginx-ingress] Added securityContext for controller daemonset
and deployment for 0.16+ versions.

* [stable/nginx-ingress] Updated to 0.16.2.

* [stable/nginx-ingress] Upgrade to 0.17.1.

* [stable/nginx-ingress] Upgraded defaultbackend to 1.4.

* [stable/nginx-ingress] README.md: Updated image tag versions.

Signed-off-by: Marek Bartik <mab@revolgy.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
* [stable/nginx-ingress] Added securityContext for controller daemonset
and deployment for 0.16+ versions.

* [stable/nginx-ingress] Updated to 0.16.2.

* [stable/nginx-ingress] Upgrade to 0.17.1.

* [stable/nginx-ingress] Upgraded defaultbackend to 1.4.

* [stable/nginx-ingress] README.md: Updated image tag versions.

Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
* [stable/nginx-ingress] Added securityContext for controller daemonset
and deployment for 0.16+ versions.

* [stable/nginx-ingress] Updated to 0.16.2.

* [stable/nginx-ingress] Upgrade to 0.17.1.

* [stable/nginx-ingress] Upgraded defaultbackend to 1.4.

* [stable/nginx-ingress] README.md: Updated image tag versions.

Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants