-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/nginx-ingress] Upgrade to 0.17.1 #6745
Conversation
/retest |
Can you also update defaultbackend image to the one referenced in upstream documentation: gcr.io/google_containers/defaultbackend:1.4 |
Also see #7001 |
I have no idea why the |
@sebastien-prudhomme Done. |
@@ -5,7 +5,7 @@ controller: | |||
name: controller | |||
image: | |||
repository: quay.io/kubernetes-ingress-controller/nginx-ingress-controller | |||
tag: "0.15.0" | |||
tag: "0.17.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the readme to match the values.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -291,7 +291,7 @@ defaultBackend: | |||
name: default-backend | |||
image: | |||
repository: k8s.gcr.io/defaultbackend | |||
tag: "1.3" | |||
tag: "1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Reference to docs explaining why securityContext needs update: https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.16.2 |
/ok-to-test |
/assign @lachie83 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, jpds, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [stable/nginx-ingress] Added securityContext for controller daemonset and deployment for 0.16+ versions. * [stable/nginx-ingress] Updated to 0.16.2. * [stable/nginx-ingress] Upgrade to 0.17.1. * [stable/nginx-ingress] Upgraded defaultbackend to 1.4. * [stable/nginx-ingress] README.md: Updated image tag versions. Signed-off-by: Marek Bartik <mab@revolgy.com>
* [stable/nginx-ingress] Added securityContext for controller daemonset and deployment for 0.16+ versions. * [stable/nginx-ingress] Updated to 0.16.2. * [stable/nginx-ingress] Upgrade to 0.17.1. * [stable/nginx-ingress] Upgraded defaultbackend to 1.4. * [stable/nginx-ingress] README.md: Updated image tag versions. Signed-off-by: aba182 <ajwilhel@gmail.com>
* [stable/nginx-ingress] Added securityContext for controller daemonset and deployment for 0.16+ versions. * [stable/nginx-ingress] Updated to 0.16.2. * [stable/nginx-ingress] Upgrade to 0.17.1. * [stable/nginx-ingress] Upgraded defaultbackend to 1.4. * [stable/nginx-ingress] README.md: Updated image tag versions. Signed-off-by: Jakob Niggel <info@jakobniggel.de>
What this PR does / why we need it: Upgrade to 0.17.1.