This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Odoo - Several improvements #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
carrodher
reviewed
Jun 26, 2018
stable/odoo/README.md
Outdated
| | `livenessProbe.timeoutSeconds` | When the probe times out (ingest nodes pod) | 5 | | ||
| | `livenessProbe.failureThreshold` | Minimum consecutive failures to be considered failed | 6 | | ||
| | `livenessProbe.successThreshold` | Minimum consecutive successes to be considered successful | 1 | | ||
| | `readinessProbe.enabled` | would you like a readinessProbe to be enabled | `true` | |
There was a problem hiding this comment.
In order to use the same approach, can you use uppercase in the description?
would ...
by
Would ...
There was a problem hiding this comment.
I will use the format:
Enable/disable the readiness probe
tompizmor
reviewed
Jun 26, 2018
| @@ -4,9 +4,9 @@ metadata: | |||
| name: {{ template "odoo.fullname" . }} | |||
| labels: | |||
| app: {{ template "odoo.fullname" . }} | |||
There was a problem hiding this comment.
this should be app: {{ template "odoo.name" . }}. I would take advantage of this PR to update that in the chart
tompizmor
suggested changes
Jun 26, 2018
stable/odoo/README.md
Outdated
| | `postgresql.persistence.accessMode` | PVC Access Mode for PostgreSQL volume | `ReadWriteOnce` | | ||
| | `postgresql.persistence.size` | PVC Storage Request for PostgreSQL volume | `8Gi` | | ||
| | `livenessProbe.enabled` | Enable/disable the liveness probe | `true` | | ||
| | `livenessProbe.initialDelaySeconds` | Delay before liveness probe is initiated | 120 | |
There was a problem hiding this comment.
this does not match the value in values.yaml. There are other wrongs too
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, tompizmor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jainishshah17
added a commit
to jainishshah17/charts
that referenced
this pull request
Jun 26, 2018
* artifactory-rbac-support: updated readme bumped Artifactory version RBAC support upgrade alertmanager, prometheus, configmap-reload and node-exporter (helm#6276) Add support for AWS Secrets Manager (helm#6245) Dokuwiki - Several improvements (helm#6326) Mediawiki fix probes & improve notes (helm#6320) Odoo - Several improvements (helm#6316) Joomla! - Several improvements (helm#6322) update signalfx-agent helm chart to v0.1.2 to deploy agent v3.2.2 (helm#6202) cert-manager: fast-forward to upstream f804cb56 (helm#6308) [stable/concourse] correct the parameter name (helm#6283) # Conflicts: # stable/artifactory/Chart.yaml # stable/artifactory/README.md # stable/artifactory/values.yaml
jainishshah17
added a commit
to jainishshah17/charts
that referenced
this pull request
Jun 26, 2018
…configmap * artifactory-ha-rbac-support: (60 commits) updated readme RBAC support upgrade alertmanager, prometheus, configmap-reload and node-exporter (helm#6276) Add support for AWS Secrets Manager (helm#6245) Dokuwiki - Several improvements (helm#6326) Mediawiki fix probes & improve notes (helm#6320) Odoo - Several improvements (helm#6316) Joomla! - Several improvements (helm#6322) update signalfx-agent helm chart to v0.1.2 to deploy agent v3.2.2 (helm#6202) cert-manager: fast-forward to upstream f804cb56 (helm#6308) [stable/concourse] correct the parameter name (helm#6283) [stable/envoy] chart version 1.0.0 (helm#5955) nginx-ingress/values.yaml: Updated tag to 0.15.0. (helm#5947) [stable/keycloak] Documentation fixes (helm#6289) [sumologic-fluentd] Update to latest image and expose new configuration to control stat watcher on fluentD in_tail plugins. (helm#6304) Adds tolerations labels for Jaeger pods (helm#6255) Upgrade image version for kube-slack (helm#6305) Add katafygio chart (helm#5543) [stable/k8s-spot-rescheduler] Add support for node selector and tolerations (helm#5789) schema-registry - Templating for liveness/readiness probes (helm#6301) ... # Conflicts: # stable/artifactory-ha/Chart.yaml # stable/artifactory-ha/README.md # stable/artifactory-ha/values.yaml
or1can
pushed a commit
to or1can/charts
that referenced
this pull request
Jul 10, 2018
* Odoo - Several improvements * Recovering existing values for liveness probes * Some corrections on README.md file * Fixing labels and README.md values
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Odoo - Several improvements * Recovering existing values for liveness probes * Some corrections on README.md file * Fixing labels and README.md values Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides several improvements to Odoo Helm Chart: