This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/envoy] chart version 1.0.0 #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
needs-ok-to-test
|
/assign @scottrigby |
|
cc: @unguiculus |
|
/assign @viglesiasce |
unguiculus
suggested changes
Jun 13, 2018
stable/envoy/Chart.yaml
Outdated
| sources: | ||
| - https://github.com/envoyproxy/envoy | ||
| maintainers: | ||
| - name: Joshua M. Dotson |
| {{- end }} | ||
| {{- end }} | ||
| annotations: | ||
| checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }} |
stable/envoy/values.yaml
Outdated
| replicaCount: 2 | ||
|
|
||
| podDisruptionBudget: | ||
| maxUnavailable: 1 |
There was a problem hiding this comment.
If you want to configure a default, do it like this:
podDisruptionBudget: |
maxUnavailable: 1Otherwise, a user would not be able to use minAvailable if they wanted.
stable/envoy/values.yaml
Outdated
| # service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true" | ||
| # service.beta.kubernetes.io/aws-load-balancer-internal: "true" | ||
| ports: | ||
| n0: {port: 10000, targetPort: n0, protocol: TCP} |
There was a problem hiding this comment.
It's common practice here to use this notation:
n0:
port: 10000
targetPort: n0
protocol: TCPI'd suggest you change it everywhere.
|
/assign |
|
Thanks for your review @unguiculus . Will fix up and push asap. |
|
@unguiculus Rebased and pushed a commit with things per your review. Thanks! |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
unguiculus
approved these changes
Jun 25, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josdotso, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Ferenc-
pushed a commit
to Ferenc-/charts
that referenced
this pull request
Jun 26, 2018
* [stable/envoy] chart version 1.0.0 * [stable/envoy] Remove trailing spaces from values.yaml * [stable/envoy] Apply fixups per unguiculus' review of 1.0.0
jainishshah17
added a commit
to jainishshah17/charts
that referenced
this pull request
Jun 26, 2018
…configmap * artifactory-ha-rbac-support: (60 commits) updated readme RBAC support upgrade alertmanager, prometheus, configmap-reload and node-exporter (helm#6276) Add support for AWS Secrets Manager (helm#6245) Dokuwiki - Several improvements (helm#6326) Mediawiki fix probes & improve notes (helm#6320) Odoo - Several improvements (helm#6316) Joomla! - Several improvements (helm#6322) update signalfx-agent helm chart to v0.1.2 to deploy agent v3.2.2 (helm#6202) cert-manager: fast-forward to upstream f804cb56 (helm#6308) [stable/concourse] correct the parameter name (helm#6283) [stable/envoy] chart version 1.0.0 (helm#5955) nginx-ingress/values.yaml: Updated tag to 0.15.0. (helm#5947) [stable/keycloak] Documentation fixes (helm#6289) [sumologic-fluentd] Update to latest image and expose new configuration to control stat watcher on fluentD in_tail plugins. (helm#6304) Adds tolerations labels for Jaeger pods (helm#6255) Upgrade image version for kube-slack (helm#6305) Add katafygio chart (helm#5543) [stable/k8s-spot-rescheduler] Add support for node selector and tolerations (helm#5789) schema-registry - Templating for liveness/readiness probes (helm#6301) ... # Conflicts: # stable/artifactory-ha/Chart.yaml # stable/artifactory-ha/README.md # stable/artifactory-ha/values.yaml
or1can
pushed a commit
to or1can/charts
that referenced
this pull request
Jul 10, 2018
* [stable/envoy] chart version 1.0.0 * [stable/envoy] Remove trailing spaces from values.yaml * [stable/envoy] Apply fixups per unguiculus' review of 1.0.0
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* [stable/envoy] chart version 1.0.0 * [stable/envoy] Remove trailing spaces from values.yaml * [stable/envoy] Apply fixups per unguiculus' review of 1.0.0 Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: https://www.cncf.io/blog/2017/09/13/cncf-hosts-envoy/