[stable/redis-ha] Update redis image + Fix persistance volume claim #2543

smileisak · 2017-10-21T11:27:36Z

Update default redis image used within this chart. Related with these issues #2527, #2394

quay.io/smile/redis:4.0.2

Dockerfile can be found here.

And fix Persistance Volume Claim name to enable persistance correctly. Related with these issues:
#2539, #2386

k8s-ci-robot · 2017-10-21T11:27:43Z

Hi @smileisak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

esvirskiy · 2017-10-24T17:47:55Z

Hi @smileisak,

Are you saying that Persistence should now work with image quay.io/smile/redis:4.0.2? I just checked and it does not.

smileisak · 2017-10-24T17:51:59Z

@esvirskiy Statefulset was pointing to a wrong pvc
Changes were made here and here.

esvirskiy · 2017-10-24T17:56:36Z

@smileisak So helm install --set replicas.master=1 --set replicas.slave=3 --set persistentVolume.enabled=true --set redis_imae=quay.io/smile/redis:4.0.2 stable/redis-ha should work? I just tested and it still fails with the same errors as from #2539

smileisak · 2017-10-24T18:01:15Z

@esvirskiy While this PR not merged, it will not work !
@viglesiasce can you please review this PR ?

esvirskiy · 2017-10-24T18:03:50Z

ah, understood!

fastjames · 2017-10-24T20:54:54Z

@smileisak I am having a slightly different problem when I try to use this chart with your changes: the persistentVolumeClaim in redis-deployment.yaml has the same name as the pvc in redis-master-statefulset.yaml. When the redis node tries to attach the volume it has already been attached to another node and so the operation fails. Is there some accessMode or other configuration that fixes this when you run it? Here's a log entry from the redis-ha pod:

6m 6m 1 {controller-manager } Warning FailedMount Failed to attach volume "pvc-dc74d4a6-bcdb-11e7-b773-127b619127fe" on node "ip-172-20-123-234.ec2.internal" with: Error attaching EBS volume "vol-0734c17871f7d4198" to instance "i-0420cc6c734c0b9e8": VolumeInUse: vol-0734c17871f7d4198 is already attached to an instance

viglesiasce · 2017-10-26T18:59:15Z

/ok-to-test

viglesiasce · 2017-10-26T23:18:38Z

stable/redis-ha/values.yaml

-
-
-
+redis_image: quay.io/smile/redis:4.0.2


Can you add the source of this image in the sources of the Chart.yaml?

@scottrigby

* upstream/master: (132 commits) [stable/spinnaker] use the /health endpoint instead of /env (helm#2608) [stable/concourse] bump dependency postgresql 0.8.3 (helm#2391) [stable/redis-ha] fix: sentinel depl should use resources.sentinel (helm#2468) [stable/redis-ha] Update redis image + Fix persistance volume claim (helm#2543) redis-ha: Fix broken link to k8s.io docs (helm#2418) Adding docs on supported Kubernetes versions (helm#2581) [stable/traefik] Bump Traefik version to 1.4.1 (helm#2589) [stable/parse] Release 0.2.8 (helm#2593) [stable/redis] Release 1.0.1 (helm#2592) [stable/phabricator] Release 0.4.26 (helm#2584) [stable/odoo] Release 0.5.15 (helm#2558) [stable/ghost] Release 1.0.7 (helm#2575) Adding @scottrigby and @mattfarina to OWNERS (helm#2580) Adjusting ingress record to better support TLS (helm#2484) [stable/redis] release 1.0.0 (helm#2380) Updated the NOTES for istio. (helm#2438) [stable/redmine] Release 2.0.1 (helm#2490) [stable/mariadb] Update to mariadb non-root image (helm#2423) Update CI to use Helm 2.6.2 (helm#2405) update kubernetes-dashboard image version to v1.7.1 (helm#2514) ...

esvirskiy · 2017-10-31T15:21:00Z

I just tested and I am seeing the exact same issues when using persistent volume claim.

$ helm install --set replicas.master=1 --set replicas.slave=3 --set persistentVolume.enabled=true stable/redis-ha
NAME:   hoping-termite
LAST DEPLOYED: Tue Oct 31 11:19:03 2017
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/PersistentVolumeClaim
NAME                         STATUS   VOLUME  CAPACITY  ACCESSMODES  STORAGECLASS  AGE
hoping-termite-redis-ha-pvc  Pending  gp2     1s

==> v1/Service
NAME                     CLUSTER-IP     EXTERNAL-IP  PORT(S)    AGE
redis-sentinel           100.67.84.157  <none>       26379/TCP  0s
hoping-termite-redis-ha  100.66.78.145  <none>       6379/TCP   0s

==> v1beta1/Deployment
NAME                              DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
hoping-termite-redis-ha           3        3        3           0          0s
hoping-termite-redis-ha-sentinel  3        3        3           0          0s

==> v1beta1/StatefulSet
NAME                            DESIRED  CURRENT  AGE
hoping-termite-redis-ha-master  1        1        0s


NOTES:
Redis cluster can be accessed via port 6379 on the following DNS name from within your cluster:
hoping-termite-redis-ha.default.svc.cluster.local

To connect to your Redis server:

1. Run a Redis pod that you can use as a client:

   kubectl exec -it hoping-termite-redis-ha-master-0 bash

2. Connect using the Redis CLI:

  redis-cli -h hoping-termite-redis-ha.default.svc.cluster.local

jalberto · 2017-11-01T11:00:00Z

I have troubles with latest version too @smileisak
looks like slave and master are trying to mount same PVC

burd0047 · 2017-11-06T16:07:38Z

having the same issue.

esvirskiy · 2017-11-08T21:50:32Z

Bump?

smileisak · 2017-11-08T22:57:45Z

Sorry guys, I was not available this periode of time, i started migrating the slave deployment to statefulset and creating 2 persistant volume claims for master and slave components. It will be available soon..

esvirskiy · 2017-11-20T18:22:18Z

will this ever be fixed?

smileisak · 2017-11-20T19:06:34Z

@esvirskiy yes it was fixed

esvirskiy · 2017-11-20T19:10:42Z

I'm still seeing issues when persistent volume is enabled.

My command:
$ helm install --set replicas.master=1 --set replicas.slave=3 --set persistentVolume.enabled=true stable/redis-ha

Screenshot:

esvirskiy · 2017-11-21T17:02:42Z

@smileisak is the command above incorrect? How do I enable persistent volume?

icelynjennings · 2017-11-28T15:25:39Z

Hi, there are still some scaling issues with the PVCs, they appear not to scale:

1 PVC is created for the masters' StatefulSet, instead of 1 per replica
1 PVC is created for the slaves' StatefulSet, instead 1 per replica

As mentioned in #2386 (comment) it looks like the PVCs have to be modified to use volumeClaimTemplates

As a consequence, only one master / slave are able to start, see pictures below

renaudguerin · 2018-02-20T13:55:05Z

Hi, is anyone working on the necessary changes mentioned above ?

esvirskiy · 2018-02-21T02:29:32Z

How can I enable PersistentVolume? I have

persistentVolume:
  ## If true, redis will create/use a Persistent Volume Claim
  ## If false, use emptyDir
  ##
  enabled: true

but

 $ kubectl get pods
NAME                                                    READY     STATUS    RESTARTS   AGE
estranged-heron-kubernetes-dashboard-6b6b9bdc87-2sdg2   1/1       Running   0          9m
redis-test-redis-ha-sentinel-846dbb8999-6vk8r           1/1       Running   0          6m
redis-test-redis-ha-sentinel-846dbb8999-dhzw4           1/1       Running   0          6m
redis-test-redis-ha-sentinel-846dbb8999-l8v9m           1/1       Running   0          6m
redis-test-redis-ha-server-6d5cdf675c-lqxfh             1/1       Running   4          6m
redis-test-redis-ha-server-6d5cdf675c-lwtfq             1/1       Running   4          6m
redis-test-redis-ha-server-6d5cdf675c-z5x6h             1/1       Running   4          6m
 $ kubectl get pvc
No resources found.

smileisak · 2018-02-21T08:15:02Z

@ianmaddox can you take a look ;)

esvirskiy · 2018-02-27T20:53:50Z

@ianmaddox pretty please? :)

esvirskiy · 2018-03-06T17:15:14Z

Got redis-ha to use PVC but it does not work...


$ helm install --set replicas.master=1 --set replicas.slave=2 --set persistentVolume.enabled=true --name=whatever stable/redis-ha
NAME:   whatever
LAST DEPLOYED: Tue Mar  6 12:06:47 2018
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/PersistentVolumeClaim
NAME                   STATUS  VOLUME                                    CAPACITY  ACCESSMODES  STORAGECLASS  AGE
whatever-redis-ha-pvc  Bound   pvc-c1599d54-2160-11e8-b233-08002741a5b2  2Gi       RWO          standard      1s

==> v1/Service
NAME               CLUSTER-IP     EXTERNAL-IP  PORT(S)    AGE
redis-sentinel     10.111.25.244  <none>       26379/TCP  1s
whatever-redis-ha  10.107.53.212  <none>       6379/TCP   1s

==> v1beta1/Deployment
NAME                        DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
whatever-redis-ha           2        2        2           0          1s
whatever-redis-ha-sentinel  3        3        3           0          1s

==> v1beta1/StatefulSet
NAME                      DESIRED  CURRENT  AGE
whatever-redis-ha-master  1        1        1s


NOTES:
Redis cluster can be accessed via port 6379 on the following DNS name from within your cluster:
whatever-redis-ha.default.svc.cluster.local

To connect to your Redis server:

1. Run a Redis pod that you can use as a client:

   kubectl exec -it whatever-redis-ha-master-0 bash

2. Connect using the Redis CLI:

  redis-cli -h whatever-redis-ha.default.svc.cluster.local

$ kubectl get pvc
NAME                    STATUS    VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
whatever-redis-ha-pvc   Bound     pvc-c1599d54-2160-11e8-b233-08002741a5b2   2Gi        RWO            standard       7m

ianmaddox · 2018-03-06T19:16:56Z

Hey all. I've spent a little time with this but got hung up by the RBAC changes. More soon.

Update redis image

f02a00c

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2017

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2017

delete blank lines

46b11d3

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2017

smileisak mentioned this pull request Oct 21, 2017

Update redis-ha chart image #2394

Closed

smileisak added 5 commits October 21, 2017 13:53

fix chart version

2f651dc

delete tailing spaces

2f70b22

new line

4bfae61

new line character in the end

8398e9c

fix persistance volume claim | pvc was pointing to a wrong claim

0598044

smileisak changed the title ~~[stable/redis-ha] Update redis image~~ [stable/redis-ha] Update redis image + Fix persistance volume claim Oct 23, 2017

This was referenced Oct 23, 2017

redis-ha not working when Persistence is enabled #2539

Closed

redis-ha chart does not work with persistence #2386

Closed

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2017

viglesiasce suggested changes Oct 26, 2017

View reviewed changes

add image repos in chart's sources

066cecd

viglesiasce approved these changes Oct 27, 2017

View reviewed changes

viglesiasce merged commit 5a636b1 into helm:master Oct 27, 2017

smileisak mentioned this pull request Nov 8, 2017

[stable/redis-ha] replace slave deployment to statefulset + create separate pvc for masters and slaves #2696

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/redis-ha] Update redis image + Fix persistance volume claim #2543

[stable/redis-ha] Update redis image + Fix persistance volume claim #2543

smileisak commented Oct 21, 2017 •

edited

Loading

k8s-ci-robot commented Oct 21, 2017

esvirskiy commented Oct 24, 2017

smileisak commented Oct 24, 2017 •

edited

Loading

esvirskiy commented Oct 24, 2017

smileisak commented Oct 24, 2017

esvirskiy commented Oct 24, 2017

fastjames commented Oct 24, 2017

viglesiasce commented Oct 26, 2017

viglesiasce Oct 26, 2017

smileisak Oct 27, 2017

esvirskiy commented Oct 31, 2017 •

edited

Loading

jalberto commented Nov 1, 2017

burd0047 commented Nov 6, 2017

esvirskiy commented Nov 8, 2017

smileisak commented Nov 8, 2017 •

edited

Loading

esvirskiy commented Nov 20, 2017

smileisak commented Nov 20, 2017

esvirskiy commented Nov 20, 2017

esvirskiy commented Nov 21, 2017

icelynjennings commented Nov 28, 2017

renaudguerin commented Feb 20, 2018

esvirskiy commented Feb 21, 2018

smileisak commented Feb 21, 2018

esvirskiy commented Feb 27, 2018

esvirskiy commented Mar 6, 2018

ianmaddox commented Mar 6, 2018




		redis_image: quay.io/smile/redis:4.0.2

[stable/redis-ha] Update redis image + Fix persistance volume claim #2543

[stable/redis-ha] Update redis image + Fix persistance volume claim #2543

Conversation

smileisak commented Oct 21, 2017 • edited Loading

k8s-ci-robot commented Oct 21, 2017

esvirskiy commented Oct 24, 2017

smileisak commented Oct 24, 2017 • edited Loading

esvirskiy commented Oct 24, 2017

smileisak commented Oct 24, 2017

esvirskiy commented Oct 24, 2017

fastjames commented Oct 24, 2017

viglesiasce commented Oct 26, 2017

viglesiasce Oct 26, 2017

Choose a reason for hiding this comment

smileisak Oct 27, 2017

Choose a reason for hiding this comment

esvirskiy commented Oct 31, 2017 • edited Loading

jalberto commented Nov 1, 2017

burd0047 commented Nov 6, 2017

esvirskiy commented Nov 8, 2017

smileisak commented Nov 8, 2017 • edited Loading

esvirskiy commented Nov 20, 2017

smileisak commented Nov 20, 2017

esvirskiy commented Nov 20, 2017

esvirskiy commented Nov 21, 2017

icelynjennings commented Nov 28, 2017

renaudguerin commented Feb 20, 2018

esvirskiy commented Feb 21, 2018

smileisak commented Feb 21, 2018

esvirskiy commented Feb 27, 2018

esvirskiy commented Mar 6, 2018

ianmaddox commented Mar 6, 2018

smileisak commented Oct 21, 2017 •

edited

Loading

smileisak commented Oct 24, 2017 •

edited

Loading

esvirskiy commented Oct 31, 2017 •

edited

Loading

smileisak commented Nov 8, 2017 •

edited

Loading