Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mariadb] Update to mariadb non-root image #2423

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

tompizmor
Copy link
Collaborator

This PR adapts the chart to the latest MariaDB image (10.1.28-r2) that has been migrated to a non-root approach.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @tompizmor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2017
@@ -63,7 +71,7 @@ spec:
mountPath: /bitnami/mariadb/conf/my_custom.cnf
subPath: my.cnf
- name: data
mountPath: /bitnami/mariadb
mountPath: /bitnami
Copy link
Contributor

@sameersbn sameersbn Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the mountPath would break chart upgrades. If we revert this change will it be possible to perform clean chart upgrades? Ideally we should allow existing chart deployments to be upgraded whenever possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! For the upgrade to work, the mount path has to be /bitnami/mariadb for the container and the initContainer.

@sameersbn sameersbn assigned sameersbn and unassigned sameersbn Oct 19, 2017
@sameersbn
Copy link
Contributor

@tompizmor The stable/mariadb chart has undergone a couple of updates, we need to rebase this PR and bump the version accordingly.

Bump chart version

Maintain /bitnami/mariadb as the mountPath
@tompizmor
Copy link
Collaborator Author

done @sameersbn, thanks for the notice!

@sameersbn sameersbn merged commit e6ef276 into helm:master Oct 20, 2017
dnelson pushed a commit to Vungle/charts that referenced this pull request Oct 26, 2017
* Fix non-root permissions in volume

Bump chart version

Maintain /bitnami/mariadb as the mountPath

* Use securityContext to fix non-root permission issues
fabiormoura added a commit to fabiormoura/charts that referenced this pull request Oct 28, 2017
* upstream/master: (132 commits)
  [stable/spinnaker] use the /health endpoint instead of /env (helm#2608)
  [stable/concourse] bump dependency postgresql 0.8.3 (helm#2391)
  [stable/redis-ha] fix: sentinel depl should use resources.sentinel (helm#2468)
  [stable/redis-ha] Update redis image + Fix  persistance volume claim  (helm#2543)
  redis-ha: Fix broken link to k8s.io docs (helm#2418)
  Adding docs on supported Kubernetes versions (helm#2581)
  [stable/traefik] Bump Traefik version to 1.4.1 (helm#2589)
  [stable/parse] Release 0.2.8 (helm#2593)
  [stable/redis] Release 1.0.1 (helm#2592)
  [stable/phabricator] Release 0.4.26 (helm#2584)
  [stable/odoo] Release 0.5.15 (helm#2558)
  [stable/ghost] Release 1.0.7 (helm#2575)
  Adding @scottrigby and @mattfarina to OWNERS (helm#2580)
  Adjusting ingress record to better support TLS (helm#2484)
  [stable/redis] release 1.0.0 (helm#2380)
  Updated the NOTES for istio. (helm#2438)
  [stable/redmine] Release 2.0.1 (helm#2490)
  [stable/mariadb] Update to mariadb non-root image (helm#2423)
  Update CI to use Helm 2.6.2 (helm#2405)
  update kubernetes-dashboard image version to v1.7.1 (helm#2514)
  ...
@tompizmor tompizmor deleted the fix_non_root_perm branch March 27, 2018 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants