-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/mariadb] Update to mariadb non-root image #2423
Conversation
Hi @tompizmor. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -63,7 +71,7 @@ spec: | |||
mountPath: /bitnami/mariadb/conf/my_custom.cnf | |||
subPath: my.cnf | |||
- name: data | |||
mountPath: /bitnami/mariadb | |||
mountPath: /bitnami |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the mountPath would break chart upgrades. If we revert this change will it be possible to perform clean chart upgrades? Ideally we should allow existing chart deployments to be upgraded whenever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! For the upgrade to work, the mount path has to be /bitnami/mariadb
for the container and the initContainer.
@tompizmor The stable/mariadb chart has undergone a couple of updates, we need to rebase this PR and bump the version accordingly. |
Bump chart version Maintain /bitnami/mariadb as the mountPath
c0e1908
to
e854165
Compare
done @sameersbn, thanks for the notice! |
* Fix non-root permissions in volume Bump chart version Maintain /bitnami/mariadb as the mountPath * Use securityContext to fix non-root permission issues
* upstream/master: (132 commits) [stable/spinnaker] use the /health endpoint instead of /env (helm#2608) [stable/concourse] bump dependency postgresql 0.8.3 (helm#2391) [stable/redis-ha] fix: sentinel depl should use resources.sentinel (helm#2468) [stable/redis-ha] Update redis image + Fix persistance volume claim (helm#2543) redis-ha: Fix broken link to k8s.io docs (helm#2418) Adding docs on supported Kubernetes versions (helm#2581) [stable/traefik] Bump Traefik version to 1.4.1 (helm#2589) [stable/parse] Release 0.2.8 (helm#2593) [stable/redis] Release 1.0.1 (helm#2592) [stable/phabricator] Release 0.4.26 (helm#2584) [stable/odoo] Release 0.5.15 (helm#2558) [stable/ghost] Release 1.0.7 (helm#2575) Adding @scottrigby and @mattfarina to OWNERS (helm#2580) Adjusting ingress record to better support TLS (helm#2484) [stable/redis] release 1.0.0 (helm#2380) Updated the NOTES for istio. (helm#2438) [stable/redmine] Release 2.0.1 (helm#2490) [stable/mariadb] Update to mariadb non-root image (helm#2423) Update CI to use Helm 2.6.2 (helm#2405) update kubernetes-dashboard image version to v1.7.1 (helm#2514) ...
This PR adapts the chart to the latest MariaDB image (
10.1.28-r2
) that has been migrated to a non-root approach.