Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/minio] Fix TLS can't be enabled #22470

Merged
merged 1 commit into from
May 21, 2020
Merged

[stable/minio] Fix TLS can't be enabled #22470

merged 1 commit into from
May 21, 2020

Conversation

TreeKat71
Copy link
Contributor

@TreeKat71 TreeKat71 commented May 21, 2020 •
edited
Loading

[fix] $scheme always "http"

The syntax is error, and it leads to $schema always be "http"

Is this a new chart

No

What this PR does / why we need it:

TLS can't be enabled successfully due to the go template in a wrong way.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

It has been corrected in #21373 and being wrong again in #21503.
Please check it, cause I use the latest helm chart and can't enable tls successfully.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot k8s-ci-robot requested review from krisis and nitisht May 21, 2020 07:14
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @TreeKat71. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TreeKat71 TreeKat71 changed the title Update statefulset.yaml [stable/minio] Fix TLS can't be enabled May 21, 2020
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 21, 2020
@TreeKat71
Fix TLS can't be enabled successfully due to $scheme is always "http".
5bfd9f5 
Signed-off-by: Muller Hsu <muller79924@gmail.com>
@nitisht
Copy link
Contributor

nitisht commented May 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2020
@nitisht
Copy link
Contributor

nitisht commented May 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitisht, TreeKat71

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 177c413 into helm:master May 21, 2020
@briend
Copy link
Contributor

briend commented May 21, 2020 •
edited
Loading

@capnajax you might have problems again after this has been merged, please check your SSL certs, etc.

hdifilwy
hdifilwy reviewed May 22, 2020
View reviewed changes
stable/minio/templates/statefulset.yaml
@@ -4,7 +4,7 @@
{{ $drivesPerNode := .Values.drivesPerNode | int }}
{{ $scheme := "http" }}
{{- if .Values.tls.enabled }}
{{ $scheme := "https" }}
{{ $scheme = "https" }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got error on this change with helm v2.10

Error: parse error in "minio/templates/statefulset.yaml": template: minio/templates/statefulset.yaml:7: unexpected "=" in operand

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the go version, please refer to helm/helm#4987
BTW, I use Helm 3

irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@TreeKat71
Fix TLS can't be enabled successfully due to $scheme is always "http". (
5311ec0 
helm#22470)

Signed-off-by: Muller Hsu <muller79924@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@TreeKat71 @includerandom
Fix TLS can't be enabled successfully due to $scheme is always "http". (
9898feb 
helm#22470)

Signed-off-by: Muller Hsu <muller79924@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@TreeKat71 @li-adrienloiseau
Fix TLS can't be enabled successfully due to $scheme is always "http". (
dec26ab 
helm#22470)

Signed-off-by: Muller Hsu <muller79924@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@TreeKat71
Fix TLS can't be enabled successfully due to $scheme is always "http". (
ec8eac3 
helm#22470)

Signed-off-by: Muller Hsu <muller79924@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hdifilwy hdifilwy hdifilwy left review comments

@krisis krisis Awaiting requested review from krisis

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TreeKat71 @k8s-ci-robot @nitisht @briend @hdifilwy @helm-bot