[stable/minio] corrected syntax error in statefulset

[capnajax]

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Syntax error in Statefulset prevented installation from working.

Which issue this PR fixes

Syntax error

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Thomas Wilkinson thomas@capnajax.com

[k8s-ci-robot]

Hi @capnajax. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[capnajax]

/assign @krisis

[krisis]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capnajax, krisis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/minio/OWNERS [krisis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[briend]

This PR reverts the fix I had submitted previously,
FYI:
https://stackoverflow.com/questions/17891226/difference-between-and-operators-in-go

The := operator is an assignment and declaration in one. Therefore:

{{ $scheme := "http" }}
 {{- if .Values.tls.enabled }}
 {{ $scheme := "https" }}
 {{ end }}

If tls is enabled, this will simply declare and assign a new variable "scheme" that only exists until the {{ end }}. ie, it will have zero effect on actually enabling https for minio.

Effectively, scheme is now always "http". If the previous fix broke anything, it is probably because you have enabled tls and there are issues with your certificates. Rather than revert the fix you could simply set tls to disabled or figure out the issues with the certs.

[macgyver603]

@krisis the PR @briend is referencing is #21373, which fixed the scoping issue that this PR reintroduced

[TreeKat71]

Why it was merged? It seems wrong, and I can't enable TLS successfully.