Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/couchdb] Update CouchDB to latest release, add Search #14822

Merged
merged 2 commits into from
Jun 17, 2019
Merged

[incubator/couchdb] Update CouchDB to latest release, add Search #14822

merged 2 commits into from
Jun 17, 2019

Conversation

@kocolosk
Copy link
Contributor

@kocolosk kocolosk commented Jun 14, 2019 •
edited
Loading

What this PR does / why we need it:

  1. Updates the CouchDB chart to use the latest official release.
  2. Adds an experimental integration with a companion full-text search system powered by Lucene.

Special notes for your reviewer:

The experimental functionality is disabled by default, and requires a custom build of CouchDB until apache/couchdb#2037 is merged and we cut a new release. If you want to test it out:

helm install incubator/couchdb --set image.repository=kocolosk/couchdb,image.tag=dreyfus-by-default,clusterSize=1,enableSearch=true --name test-search

Documentation is also being reviewed at apache/couchdb-documentation#418.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 14, 2019

Hi @kocolosk. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kocolosk added 2 commits June 14, 2019 22:08
@kocolosk
Bump to latest CouchDB release
ed4bbe8 
Signed-off-by: Adam Kocoloski <kocolosk@apache.org>
@kocolosk
Add experimental integration with Lucene search
8def514 
There is a companion open source project to CouchDB called Clouseau
that provides Lucene-powered fulltext search to CouchDB. This patch
provides a way to include Clouseau as a sidecar in each CouchDB Pod.

The latest release of CouchDB does not yet support this sidecar out of
the box; see apache/couchdb#2037. This integration is therefore
disabled by default.

Signed-off-by: Adam Kocoloski <kocolosk@apache.org>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 15, 2019
@cpanato
Copy link
Member

cpanato commented Jun 17, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2019
@cpanato
Copy link
Member

cpanato commented Jun 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, kocolosk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7f9ad7a into helm:master Jun 17, 2019
fooka03 pushed a commit to fooka03/charts that referenced this pull request Jun 17, 2019
@kocolosk @fooka03
[incubator/couchdb] Update CouchDB to latest release, add Search (hel…
327d192 
…m#14822)

* Bump to latest CouchDB release

Signed-off-by: Adam Kocoloski <kocolosk@apache.org>

* Add experimental integration with Lucene search

There is a companion open source project to CouchDB called Clouseau
that provides Lucene-powered fulltext search to CouchDB. This patch
provides a way to include Clouseau as a sidecar in each CouchDB Pod.

The latest release of CouchDB does not yet support this sidecar out of
the box; see apache/couchdb#2037. This integration is therefore
disabled by default.

Signed-off-by: Adam Kocoloski <kocolosk@apache.org>
Signed-off-by: Nigel Foucha <nigel.foucha@gmail.com>
@kocolosk kocolosk mentioned this pull request Jun 17, 2019
Merged
3 tasks
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
@kocolosk @anasinnyk
[incubator/couchdb] Update CouchDB to latest release, add Search (hel…
fa54f70 
…m#14822)

* Bump to latest CouchDB release

Signed-off-by: Adam Kocoloski <kocolosk@apache.org>

* Add experimental integration with Lucene search

There is a companion open source project to CouchDB called Clouseau
that provides Lucene-powered fulltext search to CouchDB. This patch
provides a way to include Clouseau as a sidecar in each CouchDB Pod.

The latest release of CouchDB does not yet support this sidecar out of
the box; see apache/couchdb#2037. This integration is therefore
disabled by default.

Signed-off-by: Adam Kocoloski <kocolosk@apache.org>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

1 more reviewer

@cpanato cpanato cpanato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kocolosk @k8s-ci-robot @cpanato @helm-bot