-
Notifications
You must be signed in to change notification settings - Fork 221
Add search index documentation #418
Conversation
wohali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great contribution for the search index documentation. Thank you for your work! I left a few small comments.
Unfortunately, the actual API reference for the new endpoint /_search_analyze is missing. (I skimmed, there may be more, but I think this is the only one.) The reference can remain, but it should be broken out and described with the proper syntax as a new server-level endpoint somewhere inside src/api/server/common.rst.
We overlooked doing this for Mango and it's still a problem (we don't properly document the /_explain and /_find endpoints.) Let's not make the same mistake with Search.
|
I just added some documentation of the config settings for Dreyfus in the main PR that probably makes sense to include over here: apache/couchdb@0d32708 |
kocolosk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lbboe !
kocolosk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, found a couple of additional nits, almost there!
kocolosk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK now with actual comments included 😄
wohali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of my comments from last time are still unaddressed. Please resolve.
|
@wohali hmm I thought the Clouseau fallout and the analyzer list were resolved. You’re definitely right about the geo one, though. |
|
@kocolosk mostly, it's the lines-too-long stuff. I think our automated checker isn't faulting the source on it right now, but invariably, it will start doing so as soon as it hits |
|
That’s weird. The linter was definitely faulting too-long-lines earlier in the PR, and Lora fixed everything it was complaining about. I’ll take a look |
|
|
wohali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better, one minor change and one content shuffle still required.
This ensures the dreyfus options show up in the config reference.
Updates to Search documentation
Overview
Add documentation about using search indexes to query a database using Lucene Query Parser Syntax.
GitHub issue number
#417