feat: add markup scopes to themelint #3983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
AlexanderBrevig
changed the title
|
We could also have |
Comment on lines
+54
to
+59
| Require::Existence(Rule::has_either("markup.heading.1")), | ||
| Require::Existence(Rule::has_either("markup.heading.2")), | ||
| Require::Existence(Rule::has_either("markup.heading.3")), | ||
| Require::Existence(Rule::has_either("markup.heading.4")), | ||
| Require::Existence(Rule::has_either("markup.heading.5")), | ||
| Require::Existence(Rule::has_either("markup.heading.6")), |
There was a problem hiding this comment.
I think it's valid for a theme to only define markup.heading and not .marker or the .n for headings
There was a problem hiding this comment.
Defining markup.heading will make all these pass, but not defining it will force you to define everything.
There was a problem hiding this comment.
If anything I think the error should be on markup.heading instead of .1... which is a bit misleading.
I am thinking we keep it off for now, or maybe make it faillable until we know what are the options we want to lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation here #3948 (comment) it would be nice if
themelintalso catches missing markup scopes.I explicitly check all the sub keys, and not the catch all as to help people who omit the catch-all in favor of specificity.