Add gruvbox dark

[svenstaro]

Uses the official gruvbox dark hard colors.

There's already gruvbox_light so let's also have gruvbox_dark. :)

To note, it would be technically more correct to rename the original gruvbox helix theme to gruvbox_dark and have this one be called gruvbox_dark_hard but eh, it would break some configs.

[pickfire]

> cargo xtask themelint gruvbox-dark
gruvbox-dark: `ui.selection` and `ui.selection.primary` cannot be equal
gruvbox-dark: `ui.statusline.normal` and `ui.statusline.insert` cannot be equal
gruvbox-dark: `ui.statusline.normal` and `ui.statusline.select` cannot be equal
gruvbox-dark: missing `bg` for `ui.cursorline.primary`
gruvbox-dark: missing `fg` for `ui.virtual.whitespace`
gruvbox-dark: missing `fg` or `bg` for `ui.virtual.indent-guide`
gruvbox-dark: missing `fg` or `bg` for `ui.virtual.ruler`

I haven't look closely but maybe you want to resolve some of these issues? These tool is still new so it may have false positive.

[svenstaro]

Ah I just copied straight from the current gruvbox theme to make it super easy to review. Should I still change it? Might be better to change all of the themes in one big linting commit.

[the-mikedavis]

See #3285. This might want to wait on #2454 since it's only a change to the palette

[the-mikedavis]

looks like this is missing the markup scopes

helix/runtime/themes/gruvbox.toml

Lines 65 to 70 in 0d8d8a4

	"markup.heading" = "aqua1"
	"markup.bold" = { modifiers = ["bold"] }
	"markup.italic" = { modifiers = ["italic"] }
	"markup.link.url" = { fg = "green1", modifiers = ["underlined"] }
	"markup.link.text" = "red1"
	"markup.raw" = "red1"

[pickfire]

@the-mikedavis I noticed you always comments on this, should we put this in the lint? cc @AlexanderBrevig

[AlexanderBrevig]

I'll make a PR tonight

[AlexanderBrevig]

#3983

[pickfire]

Maybe you can look if it's valid and then fix the file you added for now, I didn't check if they are valid yet, then later the original authors can probably refer to this file.

[svenstaro]

So while I think that #2454 would likely be the better solution for an implementation, it shouldn't really hinder merging this particular PR even though it could be implemented more efficiently once that feature has made it in.

Can we merge in for the time being and then get rid of most of the code once the possiblity to derive a theme lands?

[AlexanderBrevig]

cargo xtask themelint gruvbox-dark

This will yield (with #3983):

gruvbox-dark: `ui.selection` and `ui.selection.primary` cannot be equal
gruvbox-dark: `ui.statusline.normal` and `ui.statusline.insert` cannot be equal
gruvbox-dark: `ui.statusline.normal` and `ui.statusline.select` cannot be equal
gruvbox-dark: missing `bg` for `ui.cursorline.primary`
gruvbox-dark: missing `fg` for `ui.virtual.whitespace`
gruvbox-dark: missing `fg` or `bg` for `ui.virtual.indent-guide`
gruvbox-dark: missing `fg` or `bg` for `ui.virtual.ruler`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.1`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.2`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.3`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.4`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.5`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.6`
gruvbox-dark: missing `fg` or `bg` for `markup.heading.marker`
gruvbox-dark: missing `fg` or `bg` for `markup.bold`
gruvbox-dark: missing `fg` or `bg` for `markup.italic`
gruvbox-dark: missing `fg` or `bg` for `markup.quote`
gruvbox-dark: missing `fg` or `bg` for `markup.list`
gruvbox-dark: missing `fg` or `bg` for `markup.link.label`
gruvbox-dark: missing `fg` or `bg` for `markup.link.url`
gruvbox-dark: missing `fg` or `bg` for `markup.link.text`
gruvbox-dark: missing `fg` or `bg` for `markup.raw.inline`
gruvbox-dark: missing `fg` or `bg` for `markup.raw.block`

[pickfire]

So while I think that #2454 would likely be the better solution for an implementation, it shouldn't really hinder merging this particular PR even though it could be implemented more efficiently once that feature has made it in.

I would like to see the markup.* headers in place as specified by @the-mikedavis before merging, the original gruvbox have it.

[the-mikedavis]

Let's call this one gruvbox_dark_hard too since it uses the dark+hard palette. We can rename gruvbox to gruvbox_dark later if we need to I suppose

[svenstaro]

I synced this up with the original gruvbox theme and fixed the name.

[pickfire]

Looks good to me. Thanks for contributing a theme. But do remember to add it to https://github.com/helix-editor/helix/wiki/Themes, even though we are currently looking to phase that out but it is still usable now.

[svenstaro]

@pickfire Cool, I added the theme preview to the wiki page.