-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File sub keymap #3063
Add File sub keymap #3063
Conversation
Sub keycaps should not use uppercase keys IMO, it makes them at least 4 chars to type and typing It's more breaking but maybe |
I like this but I agree about |
If we do decide to go with |
Having to change learned behavior and remember to make a new local config depending on the project seems wobbly, I would hate that. Configuring my language server to pick up project specific details is one thing, keybindings are supposed to be more "computer wide" IMO |
We could turn space+F into a submode instead and keep space+f as a faster shortcut for the default? |
That was the original behavior in the PR that I argued against, modes should not use uppercase, it's bothersome to type |
It's a less often used mode though. Users can always add their own keymaps to access certain pickers easier. I'm open to other suggestions but I don't want to remap |
This reverts commit 4f1e197.
Hey guys, I just found this PR while searching for something similar in terms of remapping space keybinds. For my own use I have swapped f and F because F is trickier to use because of shift, and because most of the times they do the same thing. When I do select a directory then I don't need to change the binding. I also think most of the other keybinds use only one key so adding space+ff seems weird to me (unless we make it a sub-command and in that case it would be what? space+ff and space+fF?) I think swapping f and F is prolly a good default as it behaves the same in most cases (I would think). Is there a reason we can't add the config to rebind space keybinds? If not then maybe that could be a starter? |
| ----- | ----------- | ------- | | ||
| `f` | Open file picker | `file_picker` | | ||
| `F` | Open file picker at current working directory | `file_picker_in_current_directory` | | ||
| `d` | Open file picker at current buffer's directory | `file_picker_in_buffer_directory` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about b
for this?
This is possible: [keys.normal]
space.F.c = ":config-open" |
close per #4783 |
Fixes #3052