add picker: current view dir

[mangas]

Slightly different take for #3014, looking for feedback

[dead10ck]

This looks fine to me. I have no strong preference for the key binding.

[the-mikedavis]

Looks like #3063

[mangas]

@the-mikedavis seems the other PR is still debating the submenu and such. We could split those topics and just move ahead with a simpler option while the rest is being debated?

[mangas]

I think i've addressed all the comments, please let me know if anything else is missing

[therustmonk]

I've checked the changes - works fine 👍
Also sent a short refactoring for that here: mangas#1 up to you @mangas 👋

[mangas]

I've checked the changes - works fine +1 Also sent a short refactoring for that here: mangas#1 up to you @mangas wave

Hey 👋 thanks for the PR, I used most of the suggested change only replaced the if else with a match :)

[Boscop]

When I do hx foo/bar/baz.rs and then inside helix I :open asd/sdf/qwert.rs, and then open the file picker, it's still based on foo/bar/baz.rs's current dir, not on the file I was in when I summoned the file picker, is this intended?
(Helix 23.03)

Ideally it should have at least an option (if not the default) to use the current file's dir for the file picker.

[pascalkuthe]

There are three file picker commands. Check the command picker (space-?), the default keybinding has not/will not be changed but it's easy to change the keybinding yourself.

[Boscop]

@pascalkuthe Thanks. But when I do the action to open the file picker in the current buffer's directory, literally nothing happens (the command palette disappears, but no file picker appears).
I tried on Win10 and in Ubuntu inside WSL2, same behavior. Any idea why?

Btw, relative to which dir should the normal file picker (space f) operate?
Also, space f and space F seem to do the same thing (they both open relative to the working dir that the hx process was started from, NOT relative to the path of the file that was given to hx when it was started).
If I open hx /foo/bar from being inside /asd/qwer, shouldn't space f open the picker relative to /foo and space F relative to /asd? Currently both are opening it relative to /asd.

[mlsvrts]

If anyone is new/dumb at helix like me, you can use the 'buffer directory file picker' by adding a keymap to you config.toml. For instance, to make space + e open the picker, add:

[keys.normal.space]
e = "file_picker_in_current_buffer_directory"