Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: determine rust channel from rust-toolchain.toml #2528

Open
the-mikedavis opened this issue May 22, 2022 · 0 comments
Open

CI: determine rust channel from rust-toolchain.toml #2528

the-mikedavis opened this issue May 22, 2022 · 0 comments
Labels
C-enhancement Category: Improvements upstream

Comments

@the-mikedavis
Copy link
Member

The actions-rs/toolchain action used in CI can determine which rust channel to use from the rust-toolchain.toml file rather than the explicit toolchain: stable argument passed currently.

It doesn't work perfectly at the moment. There's an upstream PR that will fix the functionality: actions-rs/toolchain#209.

For now we can fork the toolchain action and merge that PR. Eventually we should switch back to the upstream when that PR is merged.

See also:
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements upstream labels May 22, 2022
the-mikedavis added a commit to the-mikedavis/helix that referenced this issue May 22, 2022
@the-mikedavis
inherit rust toolchain channel from rust-toolchain.toml
82909cc 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. helix-editor#2528 covers switching
back to the upstream when it includes those changes.
@the-mikedavis the-mikedavis mentioned this issue May 22, 2022
Merged
the-mikedavis added a commit to the-mikedavis/helix that referenced this issue May 23, 2022
@the-mikedavis
inherit rust toolchain channel from rust-toolchain.toml
cb5fa7b 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. helix-editor#2528 covers switching
back to the upstream when it includes those changes.
the-mikedavis added a commit to the-mikedavis/helix that referenced this issue May 23, 2022
@the-mikedavis
inherit rust toolchain channel from rust-toolchain.toml
d6f898c 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. helix-editor#2528 covers switching
back to the upstream when it includes those changes.
archseer pushed a commit that referenced this issue May 23, 2022
@the-mikedavis @archseer
inherit rust toolchain channel from rust-toolchain.toml
f6531c9 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. #2528 covers switching
back to the upstream when it includes those changes.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this issue Jun 15, 2022
@the-mikedavis @mtoohey31
inherit rust toolchain channel from rust-toolchain.toml
266d406 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. helix-editor#2528 covers switching
back to the upstream when it includes those changes.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this issue Jun 15, 2022
@the-mikedavis @mtoohey31
inherit rust toolchain channel from rust-toolchain.toml
731128c 
We've forked actions-rs/toolchain and merged
actions-rs/toolchain#209
so we can take advantage of full support of `rust-toolchain.toml`.
Without that PR, the action fails because the `rustup` version
built into the runners by default is too old. helix-editor#2528 covers switching
back to the upstream when it includes those changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Improvements upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@the-mikedavis