Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when reloading a shrunk file #2506

Merged
merged 3 commits into from
May 22, 2022
Merged

Fix panic when reloading a shrunk file #2506

merged 3 commits into from
May 22, 2022

Conversation

pppKin
Copy link
Contributor

@pppKin pppKin commented May 19, 2022

a small PR to fix #2305

@the-mikedavis
Copy link
Member

I'm not sure what's up with the lints - it looks like it might be using clippy from master despite pulling in the stable rust toolchain? Even re-running the check didn't fix it 🤔

@pppKin
Copy link
Contributor Author

pppKin commented May 19, 2022

yeah maybe we should create another PR to fix those warnings

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label May 19, 2022
@pppKin
Copy link
Contributor Author

pppKin commented May 20, 2022

As for the lints, I ran cargo clean and cargo clippy -- -D warnings on my machine but no warnings/errors whatsoever. So I'm confused as well.

@the-mikedavis
Copy link
Member

It looks like rust (and clippy) 1.61.0 were released recently and the CI has already started using it. e04bb8b was just merged that fixes the lints so if you rebase on top of that, the lints CI should clear up

@pppKin
Copy link
Contributor Author

pppKin commented May 20, 2022

Ah, I updated my rust toolchain to 1.61 and indeed it would generate erros now. I have rebased onto latest master.

@archseer archseer merged commit 5c86492 into helix-editor:master May 22, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
* fix panic when reloading a shrunk file

* linting

* use scrolloff
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
* fix panic when reloading a shrunk file

* linting

* use scrolloff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when reloading a file that has shrunk
3 participants