Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Upgrade hibernate to 6.1.7.Final and eclipselink asm to 9.4.0 #6514

Merged
merged 2 commits into from
Mar 30, 2023
Merged

3.x Upgrade hibernate to 6.1.7.Final and eclipselink asm to 9.4.0 #6514

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3a706
Upgrade hibernate to 6.1.7.Final and eclipselink asm to 9.4.0
barchetta Mar 29, 2023
2fe10cf
Update comment
barchetta Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@
<version.lib.cron-utils>9.1.6</version.lib.cron-utils>
<version.lib.dropwizard.metrics>4.1.2</version.lib.dropwizard.metrics>
<version.lib.eclipselink>3.0.3</version.lib.eclipselink>
<!-- Needed only to force upgrade to ASM 9.4.0. Once eclipselink is upgraded this can be removed -->
<version.lib.eclipselink.asm>9.4.0</version.lib.eclipselink.asm>
<version.lib.el-impl>4.0.2</version.lib.el-impl>
<version.lib.etcd4j>2.18.0</version.lib.etcd4j>
<version.lib.failsafe>2.3.1</version.lib.failsafe>
Expand All @@ -60,7 +62,7 @@
<version.lib.guava>31.1-jre</version.lib.guava>
<version.lib.h2>2.1.212</version.lib.h2>
<version.lib.hamcrest>1.3</version.lib.hamcrest>
<version.lib.hibernate>6.1.4.Final</version.lib.hibernate>
<version.lib.hibernate>6.1.7.Final</version.lib.hibernate>
<version.lib.hibernate-validator>7.0.2.Final</version.lib.hibernate-validator>
<version.lib.hikaricp>5.0.1</version.lib.hikaricp>
<version.lib.hystrix>1.5.18</version.lib.hystrix>
Expand Down Expand Up @@ -881,6 +883,12 @@
<artifactId>org.eclipse.persistence.jpa</artifactId>
<version>${version.lib.eclipselink}</version>
</dependency>
<!-- Needed only to force upgrade to ASM 9.4.0. Once eclipselink is upgraded this can be removed -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe indicate why we would want to upgrade ASM to 9.4.0 and why an upgrade of Eclipselink to some other version would let us remove this. I know it, you know it, but maybe a casual reader doesn't know it.

<dependency>
<groupId>org.eclipse.persistence</groupId>
<artifactId>org.eclipse.persistence.asm</artifactId>
<version>${version.lib.eclipselink.asm}</version>
</dependency>
<dependency>
<groupId>org.hibernate.orm</groupId>
<artifactId>hibernate-core</artifactId>
Expand Down