3.x Upgrade hibernate to 6.1.7.Final and eclipselink asm to 9.4.0 #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
added
dependencies
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
reviewed
Mar 29, 2023
dependencies/pom.xml
Outdated
| @@ -881,6 +883,12 @@ | |||
| <artifactId>org.eclipse.persistence.jpa</artifactId> | |||
| <version>${version.lib.eclipselink}</version> | |||
| </dependency> | |||
| <!-- Needed only to force upgrade to ASM 9.4.0. Once eclipselink is upgraded this can be removed --> | |||
There was a problem hiding this comment.
Maybe indicate why we would want to upgrade ASM to 9.4.0 and why an upgrade of Eclipselink to some other version would let us remove this. I know it, you know it, but maybe a casual reader doesn't know it.
ljnelson
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade eclipselink asm to 9.4.0 and hibernate to 6.1.7
Note that there does not appear to be a 3.x eclipselink release with ASM 9.4.0 -- so we force upgrade of eclipselink asm instead. Once eclipselink 3.0.4 (or whatever) comes out we can remove the forced eclipselink ASM upgrade.
This enables use of Java 20 due to the upgrade of ASM to 9.4.0
See #6506