Upgrade to 5.3.1 #53
Closed
Upgrade to 5.3.1 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize for never setting up automated tests for this repo. Someone will have to test this PR manually (probably me). LGTM, but it's always crucial to run the tests to verify. :) |
Merged
|
closed in favor of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up.
I updated the python tests to work with Solr 5.x, which includes nuances in 5.0 -> 5.2.1 and another change in behavior at 5.3.1.
Issue #51 is outstanding and there is a test in java that is currently ignored.
I recreated the failing python test in java and made it passing and made the failing part an ignored test for now.