Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in #41 fix for Solr 5.3.1 #51

Closed
joekiller opened this issue Dec 9, 2015 · 3 comments
Closed

Bug in #41 fix for Solr 5.3.1 #51

joekiller opened this issue Dec 9, 2015 · 3 comments

Comments

@joekiller
Copy link
Collaborator

Working on an upgrade to 5.3.1. Bug #41 was fixed but with 5.3.1 another bug appears. The last test fails because the result is:

['"man\'s best friend"', 'canis familiaris', 'dog', 'hound', 'pooch']

instead of

['"canis familiaris"', '"man\'s best friend"', 'canis familiaris', 'dog', 'hound', 'pooch']

Here is the output:

$ nosetests test/
.................F
======================================================================
FAIL: test_queries (015-test-issue-41.TestBasic)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "hon-lucene-synonyms/test/015-test-issue-41.py
    self.tst_query('canis familiaris', 4)
  File "hon-lucene-synonyms/test/015-test-issue-41.py
    self.assertEqual(cnt, quote_cnt)
AssertionError: 2 != 4
-------------------- >> begin captured stdout << ---------------------
['"canis familiaris"', '"dog"', '"hound"', '"man\'s best friend"', '"pooch"']
Quotes found count =  10
['"canis familiaris"', '"dog"', '"hound"', '"man\'s best friend"', '"pooch"']
Quotes found count =  10
['"canis familiaris"', '"dog"', '"hound"', '"man\'s best friend"', '"pooch"']
Quotes found count =  10
['"canis familiaris"', '"dog"', '"hound"', '"man\'s best friend"', '"pooch"']
Quotes found count =  10
['"canis familiaris"', '"man\'s best friend"', 'dog', 'hound', 'pooch']
Quotes found count =  4
['"canis familiaris"', '"man\'s best friend"', 'dog', 'hound', 'pooch']
Quotes found count =  4
['"canis familiaris"', '"man\'s best friend"', 'dog', 'hound', 'pooch']
Quotes found count =  4
['"man\'s best friend"', 'canis familiaris', 'dog', 'hound', 'pooch']
Quotes found count =  2

--------------------- >> end captured stdout << ----------------------

----------------------------------------------------------------------
Ran 18 tests in 2.058s

FAILED (failures=1)

Not sure the problem immediately but working on it...

@joekiller
Copy link
Collaborator Author

I'm not positive but I think this has to do with https://issues.apache.org/jira/browse/LUCENE-6400

@nolanlawson
Copy link
Member

Fixed in 2.0.0; thanks a ton for your PR! :)

BTW you are now a collaborator on this project. Feel free to +1 and merge pull requests; it's a pretty lax environment, but I think now that we have Travis tests, we should at least try to keep the badge green. :)

@joekiller
Copy link
Collaborator Author

Sounds good thanks! I think we can close this as it was more of a lucene change and to make it known how it affected the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants