Use hermetic python #240
Merged
Use hermetic python #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what is causing the CI failures and I don't have the access to the logs. @proppy, @QuantamHD could you please paste those for me? |
|
ericastor
requested changes
Dec 14, 2023
lpawelcz
force-pushed
the
use-hermetic-python
branch
from
f9c7107 to
17db21c
Compare
Remove cpython toolchain and embedded_python_interpreter. Use provided hermetic python interpreter from rules_python instead Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
ericastor
approved these changes
Dec 14, 2023
proppy
reviewed
Dec 22, 2023
| @@ -132,10 +132,12 @@ def _get_test_command(ctx, verilog_files, vhdl_files): | |||
| seed_args = " --seed {}".format(ctx.attr.seed) if ctx.attr.seed != "" else "" | |||
|
|
|||
| test_module_args = _pymodules_to_argstring(ctx.files.test_module, "test_module") | |||
| python_interpreter = ctx.toolchains["@bazel_tools//tools/python:toolchain_type"].py3_runtime.interpreter.path | |||
There was a problem hiding this comment.
shouldn't we be using:
toolchain="@rules_python//python:current_py_toolchain"
and
${PYTHON3}
as recommended in https://rules-python.readthedocs.io/en/latest/getting-started.html#toolchain-usage-in-other-rules ?
proppy
reviewed
Dec 22, 2023
| @@ -81,6 +82,7 @@ def _gds_write_impl(ctx): | |||
| gds_allow_empty_args + | |||
| " --out {}".format(final_gds.path), | |||
| tools = depset([ctx.executable._gds_write]), | |||
| toolchain = "//python:current_py_toolchain", | |||
There was a problem hiding this comment.
shouldn't we be using:
toolchain="@rules_python//python:current_py_toolchain"
as recommended in https://rules-python.readthedocs.io/en/latest/getting-started.html#toolchain-usage-in-other-rules ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
This PR removes
cpython toolchainandembedded_python_interpreter. It replaces those with python interpreter taken from rules_python which is a proper way of handling hermetic python toolchain.Additional modifications take into account explicit calls to python in rules like
cocotborgds_write.Those modifications are also required to allow the usage of
gds_writerule in XLS repository (see google/xls#1031)CC @proppy