Release/0.9.0 #340
Merged
Release/0.9.0 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.8.0 Feature/re merge to develop after 0.8.0
Adding timeout to dbus call as well to make sure it doesn't hang forever
`_uuid` is not defined. Updating to point to `uuid` property.
Also adding Interfaces again...
Prevent overwriting address in dbus client
Catch RemoteError in is_connected in BlueZ backend (#310)
Checking the formatting and linting only needs to run once per pull request. Also, this will allow the other tests to run even if there is a format or lint error.
github: use --check instead of --diff for black
This adds an event waiter so that `BleakClientDotNet.disconnect()` will actually await the disconnection event before returning. This is a partial fix for #313.
… on disconnect When device was disconnected and reconnected, we would end up with multiple disconnect handlers since the underlying .NET object was reused. By keeping the event registration token, we are able to remove the event handler when we lose the connection to the device. This should fix #312.
If we keep this, then we can reconnect without having to run `BleakScannerDotNet.find_device_by_address()` again during `connect()`.
All backends had the same implementation, so it can be moved to the abstract base class. BleakGATTService.uuid properties are modified so that all platforms return a lower case xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx string. The filter is modified so that if a string argument is given, then it will be converted to lower case to match the uuid property.
For the most part, we have standardized on storing and returning UUIDs as strings with lower case hex digits in the format xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. On the other hand, arguments to functions and methods should be case insensitive to make it easy for end users. This fixes some cases that didn't adhere to these principals.
This changes the type of the _uuid argument in cb_uuid_to_str() to CBUUID. This saves all callers from having to call UUIDString()
This removes use of the BleakBridge for managing ValueChanged and replaces it with a pure Python implementation.
This uses a common implementation for the `BleakGATTCharacteristic.description()` method. This will potentially change the return value on Windows, but it ensures that we get the same result on all platforms.
`BleakGATTDescriptor` provides an implementation for the `description` property, but two of the backends were overriding it with something else.
Scheduled daily dependency update on Thursday
This changes the dotnet Bleak client to use a GattSession object to manage the connection lifecycle. Creating a GattSession with MaintainConnection set to True seems a bit more straight forward than depending on other API calls to implicitly initiate and maintain the connection.
This changes the ConnectionStatusChanged event handler so that it only calls loop.call_soon_threadsafe() once per callback.
UUID fixes and cleanups
…sertion crashes if disconnect is called more than once.
Windows connection fixes
Avoiding 'None' case when disconnecting
doc: add troubleshooting page
* Adding a timeout on OSX so that the connect cannot hang forever. * Using asyncio.wait_for and events for timeout * Applied formatting * Implementing suggestions * Removing unused import
* fix NUS uuids Co-authored-by: Carglglz <carlosgilglez@gmail.com>
hbldh
added
Backend: pythonnet
|
@dlech I have merged all existing reviewed PRs, tested the code using my peripherals and machines and updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
BleakBridgeimports.Changed
BleakCharacteristic.description()on .NET now returns the same value as other platforms.+=/-=syntax to callingadd_andremove_methods instead. This allows for proper removal of event handlers in .NET backend.BleakBridgeis now removed. It is only imported to allow for access to UWP namespaces._start_notifyin the .NET backend.GattSessionobject now manages lifetime of .NETBleakClientconnection.BleakClientin .NET backend will reuse previous device information when reconnecting so that it doesn't have to scan/discover again.Fixed
_uuidis not defined. Updating to point touuidproperty. #307.BleakGATTService.get_characteristic()method overridden withNotImplementedErrorin BlueZ backend.AttributeErrorwhen trying to connect using CoreBluetooth backend. Merged Fix corebluetooth client issue #319 #323.BleakClient.disconnect()method failing when called multiple times in .NET backend. Fixes AttributeError: 'NoneType' object has no attribute 'Dispose' when disconnecting devices that have previously disconnected due to range/power off/etc #313.BleakClient.disconnect()method failing when called multiple times in Core Bluetooth backend. Merge Avoiding 'None' case when disconnecting #333.is_connectedin BlueZ backend. Fixes RemoteError when trying to disconnect #310,BleakClientin BlueZ backend. Merge Prevent overwriting address in dbus client #311.