Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overwriting address in dbus client #311

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Prevent overwriting address in dbus client #311

merged 1 commit into from
Sep 28, 2020

Conversation

soldag
Copy link
Contributor

@soldag soldag commented Sep 28, 2020

This will cause errors when passing a BleDevice instance as argument. Base class already handles this and sets the address according to the type of address_or_ble_device.

@hbldh hbldh self-assigned this Sep 28, 2020
@hbldh hbldh added Backend: BlueZ Issues and PRs relating to the BlueZ backend bug Something isn't working labels Sep 28, 2020
@hbldh hbldh merged commit 7ef5d61 into hbldh:develop Sep 28, 2020
@hbldh
Copy link
Owner

hbldh commented Sep 28, 2020

Very good; thank you!

This was referenced Oct 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hbldh hbldh

Labels
Backend: BlueZ Issues and PRs relating to the BlueZ backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soldag @hbldh