Notify callback rework #1020
Merged
Notify callback rework #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Repeated code for BleakClient.start_notify() is moved from the backends to the top-level BleakClient class. * self._notification_callbacks is removed from BaseBleakClient since it is not used in all backends. * A new (internal) NotifyCallback type alias is added so we don't have to repeat the Callable with args multiple times. * BaseBleakClient.start_notify() arg types are changed. The battery workaround in the BlueZ backend is removed since the refactored top-level code will fail before calling the backend code. Hopefully this should mostly go unnoticed since it will only affect BlueZ < 5.55 and most users are reporting at least that version on GitHub.
This is a breaking change that changes the first argument of the notification callback from the handle to the BleakGATTCharacteristic object. This has been a commonly reported problem by users (so much so it is in our troubleshooting guide which can now be removed) and #759 has received positive feedback for the breaking change. It is likely that most users don't use the first argument anyway, so in those cases, this won't actually be a breaking change. Fixes: #759
dlech
force-pushed
the
notify-callback-rework
branch
from
ade9acc
to
f20705f
Compare
|
Hello, I am trying to use this new feature, but not sure how. My use case: I am connecting to multiple identical devices, and want to set up a notification for the same characteristic in all the devices. Eg. identical temperature sensors in different rooms. How does the Thanks! |
|
There is still some additional work that needs to be done to add a "parent" property to the characteristics and services to be able to get the BleakClient from the characteristic object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #759.
See commit messages and the issue for details.