-
Notifications
You must be signed in to change notification settings - Fork 74
Use the Viridian name for cloud discovery documentations #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,15 +11,15 @@ | |
|
||
class HazelcastCloudAddressProvider: | ||
"""Provides initial addresses for client to find and connect to a node | ||
and resolves private IP addresses of Hazelcast Cloud service. | ||
and resolves private IP addresses of Hazelcast Viridian service. | ||
""" | ||
|
||
def __init__(self, token, connection_timeout): | ||
self.cloud_discovery = HazelcastCloudDiscovery(token, connection_timeout) | ||
self._private_to_public = dict() | ||
|
||
def load_addresses(self): | ||
"""Loads member addresses from Hazelcast Cloud endpoint. | ||
"""Loads member addresses from Hazelcast Viridian endpoint. | ||
|
||
Returns: | ||
tuple[list[hazelcast.core.Address], list[hazelcast.core.Address]]: The possible member addresses | ||
|
@@ -30,7 +30,7 @@ def load_addresses(self): | |
# Every private address is primary | ||
return list(nodes.keys()), [] | ||
except Exception as e: | ||
_logger.warning("Failed to load addresses from Hazelcast Cloud: %s", e) | ||
_logger.warning("Failed to load addresses from Hazelcast Viridian: %s", e) | ||
return [], [] | ||
|
||
def translate(self, address): | ||
|
@@ -58,11 +58,11 @@ def refresh(self): | |
try: | ||
self._private_to_public = self.cloud_discovery.discover_nodes() | ||
except Exception as e: | ||
_logger.warning("Failed to load addresses from Hazelcast.cloud: %s", e) | ||
_logger.warning("Failed to load addresses from Hazelcast Viridian: %s", e) | ||
|
||
|
||
class HazelcastCloudDiscovery: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about the name of the class? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't change that, as it is sometimes used in the wild for monkey patching the coordinator URL. We would break people's code. The same goes for the configuration element |
||
"""Discovery service that discover nodes via Hazelcast.cloud | ||
"""Service that discovers nodes via Hazelcast Viridian. | ||
https://api.viridian.hazelcast.com/cluster/discovery?token=<TOKEN> | ||
""" | ||
|
||
|
@@ -78,7 +78,7 @@ def __init__(self, token, connection_timeout): | |
self._ctx = ssl.create_default_context() | ||
|
||
def discover_nodes(self): | ||
"""Discovers nodes from Hazelcast.cloud. | ||
"""Discovers nodes from Hazelcast Viridian. | ||
|
||
Returns: | ||
dict[hazelcast.core.Address, hazelcast.core.Address]: Dictionary that maps private | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this term in Java client docs? @Serdaro Should we update them as well? FYI