Use the Viridian name for cloud discovery documentations #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now defaulting to the Viridian, instead of Cloud, so that our documentation should also reflect that. Therefore, I have replaced usages of Hazelcast Cloud with Hazelcast Viridian in this PR.
mdumandag
force-pushed
the
cloud-to-viridian
branch
from
10d2503 to
e7ca780
Compare
srknzl
reviewed
Mar 28, 2023
| - Client Runtime Stats | ||
| - Client Operating Systems Stats | ||
| - Hazelcast Cloud Discovery | ||
| - Hazelcast Viridian Discovery |
There was a problem hiding this comment.
Do we use this term in Java client docs? @Serdaro Should we update them as well? FYI
srknzl
reviewed
Mar 28, 2023
| _logger.warning("Failed to load addresses from Hazelcast Viridian: %s", e) | ||
|
|
||
|
|
||
| class HazelcastCloudDiscovery: |
There was a problem hiding this comment.
What about the name of the class?
There was a problem hiding this comment.
We can't change that, as it is sometimes used in the wild for monkey patching the coordinator URL. We would break people's code. The same goes for the configuration element cloud_discovery_token
srknzl
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now defaulting to the Viridian, instead of Cloud, so that our documentation should also reflect that.
Therefore, I have replaced usages of Hazelcast Cloud with Hazelcast Viridian in this PR.