CP Subsytem - Atomic Reference #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
cp-atomic-reference
branch
from
53d086f to
9a31c4a
Compare
For the AtomicReference, implementation, code samples, documentation and tests are added. It also includes some minor docstring fixes regarding the lists in some places and some missing checks and documentation fixes for the AtomicLong.
mdumandag
force-pushed
the
cp-atomic-reference
branch
from
9a31c4a to
f1aa7eb
Compare
puzpuzpuz
approved these changes
Oct 26, 2020
| check_not_none(function, "Function cannot be None") | ||
| function_data = self._to_data(function) | ||
| codec = atomic_long_alter_codec | ||
| # 1 means return the new value. |
There was a problem hiding this comment.
That's a nice addition. I had to look at the codec and server-side code to understand what 1/0 means. 👍
Contributor
Author
|
Thanks for the review Andrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the AtomicReference, implementation, code samples, documentation and
tests are added. It also includes some minor docstring fixes regarding
the lists in some places and some missing checks and documentation fixes
for the AtomicLong.
depends on #223