Skip to content

Conversation

@mdumandag
Copy link
Contributor

depends on #222

This PR adds CP-related codecs, AtomicLong implementation, documentation, and tests.

It also makes Future#continue_with support continuations that return Future by chaining them. It will be useful while implementing other proxies.

Protocol PR: hazelcast/hazelcast-client-protocol#346

Added a codepath that takes care of continuation functions that
returns another future by chaining them to the returned future.
@mdumandag
Copy link
Contributor Author

verify

@puzpuzpuz puzpuzpuz self-requested a review October 26, 2020 07:49
Copy link

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few nits.

@mdumandag
Copy link
Contributor Author

Thanks a lot for the review Andrey, I am merging it

@mdumandag mdumandag merged commit ccbda5f into hazelcast:master Oct 26, 2020
@mdumandag mdumandag deleted the cp-atomic-long branch October 26, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants