Skip to content

Commit

Permalink
Fix the build with rmw_fastrtps_dynamic. (ros2#1416) (ros2#1439)
Browse files Browse the repository at this point in the history
When building with *only* rmw_fastrtps_dynamic, there is
no test named "test_play_services__rmw_fastrtps_cpp" to
mark as xfail.  Instead, it is called
"test_play_services__rmw_fastrtps_dynamic_cpp", so make
sure to add a different xfail marking for that test.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 744cdf0)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
  • Loading branch information
mergify[bot] and clalancette authored Aug 11, 2023
1 parent 80bd363 commit 58aa739
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rosbag2_transport/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,12 @@ function(create_tests_for_rmw_implementation)
ament_add_test_label(test_play_services__rmw_cyclonedds_cpp xfail)
endif()

if(${rmw_implementation} MATCHES "rmw_fastrtps(.*)")
if(${rmw_implementation} MATCHES "rmw_fastrtps_cpp")
ament_add_test_label(test_play_services__rmw_fastrtps_cpp xfail)
endif()
if(${rmw_implementation} MATCHES "rmw_fastrtps_dynamic_cpp")
ament_add_test_label(test_play_services__rmw_fastrtps_dynamic_cpp xfail)
endif()
endfunction()

if(BUILD_TESTING)
Expand Down

0 comments on commit 58aa739

Please sign in to comment.