Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] Fix the build with rmw_fastrtps_dynamic. (backport #1416) #1439

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 9, 2023

This is an automatic backport of pull request #1416 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When building with *only* rmw_fastrtps_dynamic, there is
no test named "test_play_services__rmw_fastrtps_cpp" to
mark as xfail.  Instead, it is called
"test_play_services__rmw_fastrtps_dynamic_cpp", so make
sure to add a different xfail marking for that test.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 744cdf0)
@mergify mergify bot requested a review from a team as a code owner August 9, 2023 15:05
@mergify mergify bot requested review from gbiggs and jhdcs and removed request for a team August 9, 2023 15:05
@Crola1702
Copy link
Contributor

Crola1702 commented Aug 9, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

clalancette commented Aug 9, 2023

New CI pointing to the humble branches:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 58aa739 into humble Aug 11, 2023
13 checks passed
@clalancette clalancette deleted the mergify/bp/humble/pr-1416 branch August 11, 2023 12:37
@MichaelOrlov MichaelOrlov changed the title Fix the build with rmw_fastrtps_dynamic. (backport #1416) [humble] Fix the build with rmw_fastrtps_dynamic. (backport #1416) Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants