Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: add bosnian version for readme #3107

Merged
merged 18 commits into from
Dec 25, 2019
Merged

translation: add bosnian version for readme #3107

merged 18 commits into from
Dec 25, 2019

Conversation

hajro92
Copy link
Contributor

@hajro92 hajro92 commented Oct 12, 2019 •
edited
Loading

Description

Added Bosnian translation for Readme. (#hacktoberfest)

Affected components

  • Docs

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @hajro92, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ marionschleifer
✅ hajro92
❌ Hajro

Hajro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Oct 12, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit ecd69cd

https://deploy-preview-3107--hasura-docs.netlify.com

marionschleifer
marionschleifer requested changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajro92 thank you for your contribution 🙂 I left one comment at the bottom. Could you also please add the Bosnian translation here: https://github.com/hasura/graphql-engine/tree/master/translations.

@marionschleifer marionschleifer added the c/community Related to community content label Oct 12, 2019
@marionschleifer
Copy link
Contributor

@hajro92 I can't see the Bosnian translation in the README:

image

@marionschleifer
Copy link
Contributor

Also, this one doesn't look right:

image

@hajro92
Copy link
Contributor Author

hajro92 commented Oct 12, 2019

@hajro92 I can't see the Bosnian translation in the README:

image

I really added it:
image

@marionschleifer
Copy link
Contributor

@hajro92 there was something wrong with the spaces. I fixed it. The flag for Bosnia didn't show and I didn't find one for Github, so I removed it. Thank you for your work 🙂

@hajro92
Copy link
Contributor Author

hajro92 commented Oct 13, 2019 •
edited
Loading

Could you possibly add #hacktoberfest tag to it? :)

shahidhk
shahidhk requested changes Oct 26, 2019
View reviewed changes
@hajro92 hajro92 requested review from shahidhk October 26, 2019 09:55
marionschleifer
marionschleifer requested changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some links that don't work. Would be great if you could fix them 🙂

marionschleifer
marionschleifer requested changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@marionschleifer marionschleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one last link in the title of contents that is not working, the rest looks perfect 🙂 also, could you please send an email to marion@hasura.io, so that we can arrange the shipping of your swag?

@marionschleifer marionschleifer added community-contrib 🙏🏽 and removed c/community Related to community content labels Dec 24, 2019
@hajro92 hajro92 requested a review from rikinsk as a code owner December 25, 2019 17:09
@shahidhk shahidhk changed the title Added Bosnian translation for Readme.md translation: add bosnian version for readme Dec 25, 2019
@shahidhk shahidhk merged commit c1d121b into hasura:master Dec 25, 2019
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @hajro92! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3107.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@marionschleifer @shahidhk @polRk
translation: add bosnian version for readme (hasura#3107)
e3249b0 
Co-authored-by: Marion Schleifer <marion@hasura.io>
Co-authored-by: Shahidh K Muhammed <shahidh@hasura.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@marionschleifer marionschleifer marionschleifer left review comments

@rikinsk rikinsk Awaiting requested review from rikinsk

Assignees
No one assigned
Labels
community-contrib 🙏🏽
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hajro92 @hasura-bot @CLAassistant @marionschleifer @shahidhk