Add lazier versions of the TQueue and TBQueue reading functions#62
Open
edmundnoble wants to merge 2 commits intohaskell:masterfrom
Open
Add lazier versions of the TQueue and TBQueue reading functions#62edmundnoble wants to merge 2 commits intohaskell:masterfrom
edmundnoble wants to merge 2 commits intohaskell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user of
TQueueandTBQueueI don't really mind that the queue is amortized and not real-time. However I do want the power to reverse the write end of the queue without evaluating the elements of the queue, which is not possible right now as the datatype is opaque.This PR adds "read" functions that use
Soloto let the user separate the write end's reversal from the evaluation of elements, and reimplements the existing "read" functions using them.I think it should be less controversial than #12 and not require extensive benchmarking, but #12 makes this PR unnecessary. #11 would perhaps be improved by something like this PR but it's not as important for #11.