Make TQueue persist work across transactions#11
Open
treeowl wants to merge 1 commit intohaskell:masterfrom
Open
Make TQueue persist work across transactions#11treeowl wants to merge 1 commit intohaskell:masterfrom
treeowl wants to merge 1 commit intohaskell:masterfrom
Conversation
Contributor
Author
|
I haven't written proper tests for this, and haven't benchmarked it, but since I'd gotten pretty far along before @simonmar told me it wasn't a priority, I figured I'd at least get it down as a PR. |
treeowl
force-pushed
the
persq
branch
4 times, most recently
from
5a14bf3 to
4404fad
Compare
Previously, `TQueue` could build up a large write list, leading to the reader having to do too much work reversing it and aborting. Rotate the queue more frequently so the reversal work will effectively be saved even when a transaction aborts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
TQueuecould build up a large write list, leadingto the reader having to do too much work reversing it and aborting.
Rotate the queue more frequently so the reversal work will effectively
be saved even when a transaction aborts.