configure: Ensure that posix_spawnp reports ENOENT correctly #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that POSIX allows implementations to report errors "lazily" by exiting the spawned process with code 127. In particular, OpenBSD's implementation returns successfully if the requested executable doesn't exist. This severely hampers our ability to report errors accurately. In this patch we add a `configure` test for sensible error-reporting from `posix_spawnp` and disable it if the test fails. Fixes haskell#224.
|
@blackgnezdo, could you possibly test this? |
I'd be happy to. Is there a better way than plugging this into a full ghc build? I remember having trouble building |
|
Here's the result after running |
|
Works great for me on -current OpenBSD. |
snoyberg
approved these changes
Feb 9, 2022
|
It would be great to get a new |
|
Sure, I'll do that now, I just wanted to wait on #225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that POSIX allows implementations to report
errors "lazily" by exiting the spawned process with code 127.
In particular, OpenBSD's implementation returns successfully if the
requested executable doesn't exist. This severely hampers our ability to
report errors accurately.
In this patch we add a
configuretest for sensible error-reportingfrom
posix_spawnpand disable it if the test fails.Fixes #224.